librespot_connect: couldn't parse packet type 47 is invalid

[sebirdman]

In the last day or so, i've recently been unable to select the snapcast spotify stream anymore using librespot. It just doesn't show up at all.

running librespot separately like:

/usr/bin/librespot --name Snapcast --bitrate 320 --backend pipe --initial-volume 100 --verbose

Yields:

[2020-12-03T21:05:57Z INFO  librespot] librespot 89cafd7 (2020-11-27). Built on 2020-12-03. Build ID: tnGD7Qeu
[2020-12-03T21:05:57Z DEBUG librespot_connect::discovery] Zeroconf server listening on 0.0.0.0:44899
[2020-12-03T21:06:02Z WARN  libmdns::fsm] couldn't parse packet from 10.10.1.1:5353: type 47 is invalid
[2020-12-03T21:06:02Z WARN  libmdns::fsm] couldn't parse packet from [fe80::dcde:59ff:fe7e:71e5]:5353: type 47 is invalid
[2020-12-03T21:06:03Z WARN  libmdns::fsm] couldn't parse packet from 10.10.1.1:5353: type 47 is invalid
[2020-12-03T21:06:06Z WARN  libmdns::fsm] couldn't parse packet from 10.10.1.1:5353: type 47 is invalid
[2020-12-03T21:06:06Z WARN  libmdns::fsm] couldn't parse packet from [fe80::dcde:59ff:fe7e:71e5]:5353: type 47 is invalid
[2020-12-03T21:06:11Z WARN  libmdns::fsm] couldn't parse packet from 10.10.1.1:5353: type 47 is invalid
[2020-12-03T21:06:14Z WARN  libmdns::fsm] couldn't parse packet from 10.10.1.1:5353: type 47 is invalid
[2020-12-03T21:06:15Z WARN  libmdns::fsm] couldn't parse packet from 10.10.1.1:5353: type 47 is invalid
[2020-12-03T21:06:15Z WARN  libmdns::fsm] couldn't parse packet from [fe80::dcde:59ff:fe7e:71e5]:5353: type 47 is invalid
[2020-12-03T21:06:16Z WARN  libmdns::fsm] couldn't parse packet from 10.10.1.1:5353: type 47 is invalid

[sebirdman]

Interestingly, i'm able to select the stream from my desktop client, which is perhaps a bit more out of date

maybe the iPhone app updated recently?

[sebirdman]

Digging a bit further:

The error itself seems to come from https://github.com/librespot-org/libmdns/blob/stable-0.5.x/src/dns_parser/enums.rs#L265

unfortunately this appears to be invalid in all versions of the mdns library, i'm not sure what type 47 should map to

edit: this does NOT appear to be the same as Spotifyd/spotifyd#379

[ashthespy]

Type 47 should map to Next Secure record from rfc4034
Would you open up an issue in libmdns for this?

Either way @willstott101 something to consider?

[sebirdman]

@ashthespy I've created the ticket over there

[sashahilton00]

https://stbuehler.github.io/rustdocs/async-dnssd/async_dnssd/ might be worth investigating after the tokio migration. The API for this crate looks clean.

[roderickvd]

@Johannesd3 has proposed librespot-org to take ownership over dns-sd and improve on it. But for now, this is an issue upstream rather than in librespot. Thanks for reporting it there.

[MichaelUray]

@ashthespy I've created the ticket over there

Just for reference, that is the according ticket:
librespot-org/libmdns#19