Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Windows XP support #237

Closed
mcuee opened this issue Jan 26, 2021 · 8 comments
Closed

Drop Windows XP support #237

mcuee opened this issue Jan 26, 2021 · 8 comments
Labels
Windows Related to Windows backend

Comments

@mcuee
Copy link
Member

mcuee commented Jan 26, 2021

From #133.
It may be a good idea to drop Windows XP support. libusb has done that for Windows.

@mcuee mcuee added the Windows Related to Windows backend label Jan 26, 2021
@Youw
Copy link
Member

Youw commented Jan 26, 2021

Maybe.
It just don't really solve anything in context of #133. #146 - does. I've described it in details.

@mcuee
Copy link
Member Author

mcuee commented Jan 26, 2021

Yes it does not sort the issue of #133.

But then it may still be a good idea to upgrade from CancelIo to CancelIoEx.

@Youw
Copy link
Member

Youw commented Jan 26, 2021

What I afraid the most - it will hide the #133 issue deep enough so some users will start thinking that there is no issue.
I always favor an explicit crash/hang/error (so it is reproducible, can be easily debugged/fixed) instead of an "undefined behavior" that may hit you one in a million times.

In other words: hid_close better not try to interrupt hid_read (explicitly or implicitly) unless it is going to wait for its completion (which is not the case for any of the backends).

@mcuee
Copy link
Member Author

mcuee commented Apr 20, 2021

In this case, I will close this one.

@mcuee mcuee closed this as completed Apr 20, 2021
@mcuee
Copy link
Member Author

mcuee commented Jun 14, 2021

I will keep this open even if this does not help on #133. Probably this can be considered after #133. But from what I read #133 is not easy.

@mcuee mcuee reopened this Jun 14, 2021
@mcuee
Copy link
Member Author

mcuee commented Apr 25, 2022

I think it is better to close this as it is clear that hidapi will support old OS when there are no extra efforts.

#376 (comment)

does it make sense to still support Windows XP and Vista? Or old macOS versions? Or very old Linux versions?

For as long as it doesn't require the actually effort / workarounds on a code level to support those.

@mcuee mcuee closed this as completed Apr 25, 2022
@aitap
Copy link

aitap commented Mar 7, 2023

When the use of CM_Get_DevNode_PropertyW (Vista and later) has been introduced in 11cc0e8, it was made optional. In 2551a5d, failure to resolve CM_Get_DevNode_PropertyW becomes a fatal error, which effectively drops Windows XP support.

This is not a complaint (though if you're interested, I could submit a pull request); I'm just providing information for the sake of someone else whose code will fail to initialise on an old machine and who will go searching for "Windows XP" in this repo.

@Youw
Copy link
Member

Youw commented Mar 7, 2023

Thanks for observation.
If you're interested in Windows XP support and can test it - a PR with a fix is welcome.

As for general direction - there're still older releases of HIDAPI that build&run on Windows XP, and I'm sure there'are projects that are still using it.
But until I hear about them here on Github (as an issue or a PR), I say that we can effectively abandone WindowsXP support, even if not intentionally, but as a result of a refactoring/improvement.


And even though the original topic of this conversation was about dropping WindowsXP support, effectivelly it is about a (false) workaround for #133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows Related to Windows backend
Projects
None yet
Development

No branches or pull requests

3 participants