Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkify ipfs-ish text #27

Closed
the8472 opened this issue Dec 14, 2015 · 2 comments
Closed

Linkify ipfs-ish text #27

the8472 opened this issue Dec 14, 2015 · 2 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Milestone

Comments

@the8472
Copy link
Contributor

the8472 commented Dec 14, 2015

options to turn plain /ipfs/ and ipfs:// text into links and context menu entries to open any highlighted multihash as ipfs links would be nice.

@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature UX labels Dec 14, 2015
@lidel
Copy link
Member

lidel commented Dec 14, 2015

Sounds useful 👍

My thinking:

  • A new context menu item "Open IPFS resource" visible when there is a text selection that match IPFS resource regex
  • Not sure about turning text into links. I think it could be done, but modifying pages on the fly should be configurable via checkbox on the Preferences screen and probably disabled by default.

If there is no PR with this I'll try to add it in my spare time.. some day. ;-)

@the8472
Copy link
Contributor Author

the8472 commented Dec 14, 2015

Yeah, modification of the DOM should be optional.

@lidel lidel added this to the v1.4.0 milestone Jan 3, 2016
@lidel lidel closed this as completed Jan 3, 2016
@lidel lidel reopened this Jan 3, 2016
@lidel lidel closed this as completed Jan 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants