Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar button click should display menu #32

Closed
lidel opened this issue Dec 18, 2015 · 2 comments
Closed

Toolbar button click should display menu #32

lidel opened this issue Dec 18, 2015 · 2 comments
Assignees
@lidel
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Milestone
v1.4.0

Comments

@lidel
Copy link
Member

lidel commented Dec 18, 2015

As for the ToggleButton improvements, this is what I have in mind:

The popup panel would have all items from the context menu (copy link, pin resource etc) + on/off switch for entire plugin (current onClick behaviour).
@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature UX labels Dec 18, 2015
@lidel lidel added this to the v2.0.0 milestone Dec 27, 2015
@lidel lidel self-assigned this Jan 1, 2016
@lidel
Copy link
Member Author

lidel commented Jan 1, 2016

Just FYI I started working on this and PoC looks like this (ignore typos, already fixed them :-)):

2016-01-02-002813_2560x1080_scrot

lidel added a commit that referenced this issue Jan 1, 2016
@lidel
UX: First stab at the universal button-menu
7d2b45d 
- functional work-in-progress
- implements #32
- shares code with context menu
    - added link to open webui (uses API port of go-ipfs)
    - redirect toggle is now just one of panel entries
    - some entries can be displayed only
      for IPFS resources

TODO: add regression tests where possible
@lidel lidel mentioned this issue Jan 1, 2016
Closed
lidel added a commit that referenced this issue Jan 1, 2016
@lidel
UX: First stab at the universal button-menu
6e83092 
- functional work-in-progress
- implements #32
- shares code with context menu
    - added link to open webui (uses API port of go-ipfs)
    - redirect toggle is now just one of panel entries
    - some entries can be displayed only
      for IPFS resources

TODO: add regression tests where possible
@lidel lidel modified the milestones: v1.4.0, v2.0.0 Jan 3, 2016
@lidel
Copy link
Member Author

lidel commented Jan 3, 2016

Ok, with 4c18d8f I feel it can be closed as done.

@lidel lidel closed this as completed Jan 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
1 participant
@lidel