New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to the "standard" JS linter & formatter #42

Closed

lidel opened this issue Jan 10, 2016 · 1 comment

Labels

kind/discussion kind/maintenance

Member

lidel commented Jan 10, 2016

As of now we use raw ESLint (with some opinionated settings simply copied from my other projects) while /ipfs/community/js-contribution-guidelines (#59) suggests http://standardjs.com to be used across IPFS-related projects, where possible.

I think it may be beneficial to switch and enforce it via standard-format as a pre-commit hook.

(I did a dry run and the main change from current style is the removal of semicolons.)

I'll leave this open for a week or so and if there will be no cons raised – commit the change.

lidel added the kind/discussion label

jedahan commented Jan 11, 2016

👍

lidel closed this as completed in

701443c

lidel added the kind/maintenance label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment