Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Error probably due to specific type of encoding #235

Closed
gitflo opened this issue Jan 12, 2021 · 3 comments
Closed

Internal Error probably due to specific type of encoding #235

gitflo opened this issue Jan 12, 2021 · 3 comments
Assignees
Labels
Milestone

Comments

@gitflo
Copy link

gitflo commented Jan 12, 2021

Hi there,

only "Interner Fehler" (internal error) is displayed on mails from a specific sender.

My first guess was that it's an issue due to German Umlaut characters, but that doesn't seem to be the case.

Mails with the following From are treated correctly: From: =?UTF-8?B?RmzDtnJpw6RuIEhvbGVjemVr?= <xy@some-where.de>
Mails with the following From lead to the error: From: =?utf-8?Q?Dr._Heinz_M=C3=A4rck?= <abc@foo-bar.de>

Here's the related content from Thunderbird's error console:

DKIM_Verifier.background FATAL Unexpected error during onMessageDisplayed Error: From header does not contain an address
parseFromHeader moz-extension://2e35920c-0eb9-44ff-b12d-7dd6b4c71581/modules/msgParser.mjs.js:165
verify moz-extension://2e35920c-0eb9-44ff-b12d-7dd6b4c71581/modules/AuthVerifier.mjs.js:122
<anonym> moz-extension://2e35920c-0eb9-44ff-b12d-7dd6b4c71581/content/background.mjs.js:164
background.mjs.js:164:7

Environment:
Thunderbird 78.6.0 (32-Bit)
DKIM Verifier 4.0.0pre4

Kind regards
Florian

@lieser
Copy link
Owner

lieser commented Jan 13, 2021

Thanks a lot for reporting. The problem is the dot in Dr..

From my understanding this is only valid in the Obsolete Syntax, which I left out in the parsing I needed to add during the porting to TB 78.
As this should no longer be used, I hoped I could just left it out to simplify the code.

Will try to fix this in the next release.

@lieser lieser self-assigned this Jan 13, 2021
@lieser lieser added the bug label Jan 13, 2021
@lieser lieser added this to the 4.0.0 milestone Jan 13, 2021
@lieser
Copy link
Owner

lieser commented Feb 7, 2021

This should be fixed now, you can get a test version at #199 (comment).

Please reopen the issue if it is still not working for you.

@lieser lieser closed this as completed Feb 7, 2021
@gitflo
Copy link
Author

gitflo commented Feb 8, 2021

Just been testing it. The version in dkim_verifier-4.0.0pre4.1.zip fixed this issue, great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants