Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oldValue in changed event is wrong #8

Open
pnachum opened this issue Oct 20, 2015 · 3 comments
Open

oldValue in changed event is wrong #8

pnachum opened this issue Oct 20, 2015 · 3 comments

Comments

@pnachum
Copy link

pnachum commented Oct 20, 2015

I'm using the slider with immediateResponse set to true. The arguments passed to the changed event are the new value, and an object containing oldValue, but oldValue is also the new value, instead of the previous value.

@yankeeinlondon
Copy link
Member

I'm heads down on other things at the moment but feel free to send me a PR if you need this more urgently. The problem is that this code works fine with only slideStart and slideStop events are modifying the value:

https://github.com/lifegadget/ui-slider/blob/master/addon/components/ui-slider.js#L283-L284

but with immediateResponse you also set the value on the slide event:

https://github.com/lifegadget/ui-slider/blob/master/addon/components/ui-slider.js#L67

Ok, need coffee. I will get to this at some point but just super busy at moment.

@pnachum
Copy link
Author

pnachum commented Oct 20, 2015

No worries, it's definitely not urgent. Just something I noticed and figured I should bring to your attention.

I can take a look at trying to fix it

@yankeeinlondon
Copy link
Member

thanks, will get to it but not this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants