Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT - Bootstrap Accelerator - Untested #115

Closed
wants to merge 3 commits into from

Conversation

RuntimeRacer
Copy link
Contributor

Replaces DDP Implementation with Huggingface Accelerator to allow for simpler Multi-GPU Handling (https://huggingface.co/docs/accelerate/index)

@RuntimeRacer RuntimeRacer mentioned this pull request May 4, 2023
@lifeiteng
Copy link
Owner

@RuntimeRacer Very nice work, can you verify it on mutl-gpus?

@RuntimeRacer
Copy link
Contributor Author

@RuntimeRacer Very nice work, can you verify it on mutl-gpus?

@lifeiteng Yes I will do a Multi-GPU run once I finished training current epoch on Single GPU. I had to fix some issues around #113 and #110, which caused epoch 1 to never finish until I stripped languages with non-latin charsets from my training data.

I guess that epoch 1 will finish tonight or tomorrow; then I will test the accelerator code.

@RuntimeRacer
Copy link
Contributor Author

@lifeiteng I did a first couple of test and tries the last 2 hours, however I am hitting kind of a wall when it comes to splitting the dataloaders across the GPUs. Accelerate makes assumptions like fixed batch sizes and known amount of elements in the dataset in the preparation step; however Lhotse uses it's custom Implementations to feed in data dynamically. I can't continue looking into this rn; but let me know in case you have any suggestions what we could do here.

@RuntimeRacer
Copy link
Contributor Author

I was able to fix the existing DDP implementation: #116
Not sure if Accelerator is still feasible since it seems like a lot more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants