-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create context aggregator something like a ClayManager #2353
Comments
Are you thinking of including this in We might want it to be its own package since we don't want people to have to depend on modal when they use shared. |
I actually want to expose
Hmm, I don't know if I understand this well but do you mean that if the user depends on the |
I was referencing whether we would do The dependencies of ClayManager component would be
I think we are on the same page though, if it is its own package, we should be fine with a handful of dependencies. |
Oh I see, yeah I think we're fine to have your own package. |
I am adding this to our final milestone of |
Makes sense adding a <ClayManager
value={{
// It may just be an initial empty object that can be passed to DataProvider,
// it helps to cache here and be reused on different pages...
storage: {},
// Some settings to enable the use of ModalProvider...
modal: '...',
// We may have some setting to enable or disable tooltip...
tooltip: '...',
spritemap: '...',
linkComponent: Link,
sizing: 'small'
}}
>
<MyApp />
</ClayManager> and it will force all |
I don't think design is as clear cut as that. I think they typically use a mix of all sizes in an app, so I don't think it'd make sense to default to a different size than the components already offer. Design could probably help answer this though. |
Hey @bryceosterhaus @matuzalemsteles this sounds like an interesting issue, are we going to proceed with it, or is it off the table? |
@kresimir-coko I think this is still worth it, we have some contexts out there. This was downgraded at the time, but we can re-validate the cases again and start implementing this. |
Yeah I agree with @matuzalemsteles, I think its still worth it and will probably need in the future, but it's not pressing at the moment. |
Going back to our conversations we had in #2250 related to Clay's context aggregator. I think we should start implementing this as the number of contexts within Clay is starting to grow.
The implementation may look similar to this.
The text was updated successfully, but these errors were encountered: