Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Enforce standard ".soy" import style #137

Closed
wincent opened this issue Jan 30, 2020 · 0 comments · Fixed by #138
Closed

Enforce standard ".soy" import style #137

wincent opened this issue Jan 30, 2020 · 0 comments · Fixed by #138
Labels
feature

Comments

@wincent
Copy link
Contributor

wincent commented Jan 30, 2020

Good:

import templates from './Thing.soy';

Bad:

import templates from './Thing.soy.js';

As per:
wincent added a commit that referenced this issue Jan 31, 2020
@wincent
feat!: add import-extensions rule
2464e87 
When I originally created the issue, I was thinking about ".soy.js"
imports, but in the end we may as well apply it to all ".js" imports.
See the documentation in this commit for details on why this is a
reasonable approach for our codebases, and why I think we won't need any
configurability at this time.

Closes: #137
@wincent wincent mentioned this issue Jan 31, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: add import-extensions rule liferay/eslint-config-liferay
1 participant
@wincent