This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
feat: adds no-global-fetch rule to avoid direct usage of fetch in favour of our thin wrapper #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbalsas
commented
Aug 12, 2019
| }, | ||
|
|
||
| create(context) { | ||
| let foundFetchImport = false; |
There was a problem hiding this comment.
I think this is sufficiently scoped per-context... if it's not, we can store this using some additional context information.
wincent
approved these changes
Aug 12, 2019
| @@ -66,6 +66,7 @@ The bundled `eslint-plugin-liferay` plugin includes the following [rules](./plug | |||
|
|
|||
| The bundled `eslint-plugin-liferay-portal` plugin includes the following [rules](./plugins/eslint-plugin-liferay-portal/docs/rules): | |||
|
|
|||
| - [liferay-portal/no-global-fetch](./plugins/eslint-plugin-liferay-portal/docs/rules/no-global-fetch.md): Prevents usage of unwrapped fetch to avoid possible issues related to security misconfiguration. | |||
There was a problem hiding this comment.
Yeah, obviously we need a Markdown linter to enforce order here. 😂
| @@ -0,0 +1,50 @@ | |||
| # Disallow use of global fetch (no-global-fetch) | |||
|
|
|||
| This rule guards against the direct use of the `fetch` API. As a secured-environment, Liferay Portal requests often rely on specific security headers and tokens being set in the requests. The `frontend-js-web` module offers a thin wrapp around `fetch` that takes care | |||
| # Disallow use of global fetch (no-global-fetch) | ||
|
|
||
| This rule guards against the direct use of the `fetch` API. As a secured-environment, Liferay Portal requests often rely on specific security headers and tokens being set in the requests. The `frontend-js-web` module offers a thin wrapp around `fetch` that takes care | ||
| of the most common configuration to avoid issues. |
There was a problem hiding this comment.
No need to break this one onto a new line.
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| module.exports = { | |||
| rules: { | |||
| 'no-global-fetch': require('./lib/rules/no-global-fetch'), | |||
There was a problem hiding this comment.
Should order this too, although I bet it will conflict with your other PR.
|
Ok, let me rebase and try to format things properly :D |
|
Done, @wincent! I've rebased and pushforced with an additional commit for the formatting issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.