Add the ability to add custom Run Script build phases #120
Conversation
| @@ -58,6 +59,10 @@ def treat_warnings_as_errors | |||
| def add_todo_script_phase | |||
| xcode_helper.add_todo_script_phase(@config.install_todo_script) | |||
| end | |||
|
|
|||
| @@ -9,6 +9,9 @@ | |||
| configure_git: true | |||
| warnings_as_errors: true | |||
| install_todo_script: true | |||
| install_build_scripts: | |||
| - OverlayVersionIcon | |||
| - IncreaseBuildNumber | |||
There was a problem hiding this comment.
We aren't going to want these as the defaults.
gfontenot
changed the title
|
|
||
| def add_script_phases(scripts) | ||
| if scripts | ||
| scripts.each do |script| |
There was a problem hiding this comment.
Line is too long. [111/80]
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -1,6 +1,6 @@ | |||
| module Liftoff | |||
| class ProjectConfiguration | |||
| attr_accessor :project_name, :company, :prefix, :configure_git, :warnings_as_errors, :install_todo_script, :enable_static_analyzer, :indentation_level, :warnings, :application_target_groups, :unit_test_target_groups, :use_cocoapods | |||
| attr_accessor :project_name, :company, :prefix, :configure_git, :warnings_as_errors, :install_todo_script, :enable_static_analyzer, :indentation_level, :warnings, :application_target_groups, :unit_test_target_groups, :use_cocoapods, :install_build_scripts | |||
There was a problem hiding this comment.
install_todo_script should be removed here.
| @@ -8,7 +8,9 @@ | |||
|
|
|||
| configure_git: true | |||
| warnings_as_errors: true | |||
| install_todo_script: true | |||
| install_build_scripts: | |||
There was a problem hiding this comment.
Lets rename this key to run_script_phases. That will match the format with warnings better.
| @@ -8,7 +8,8 @@ | |||
|
|
|||
| configure_git: true | |||
| warnings_as_errors: true | |||
| install_todo_script: true | |||
| run_script_phases: | |||
| - todo.sh: Warn for TODO and FIXME comments | |||
There was a problem hiding this comment.
Is "Warn for TODO and FIXME comments" a comment?
There was a problem hiding this comment.
That will end up being the name of the script phase. There will be some documentation changes for this PR that I'm going to do later.
|
this is cool 👍 |
|
👍 |
|
Rebased, squashed, and merged as a8cef3e |
No description provided.