Added a liftoffrc config flag to only prompt on attributes with no specified default value #127
Conversation
| @@ -1,6 +1,6 @@ | |||
| module Liftoff | |||
| class ProjectConfiguration | |||
| attr_accessor :project_name, :company, :prefix, :configure_git, :warnings_as_errors, :install_todo_script, :enable_static_analyzer, :indentation_level, :warnings, :application_target_groups, :unit_test_target_groups, :use_cocoapods | |||
| attr_accessor :project_name, :company, :prefix, :configure_git, :warnings_as_errors, :install_todo_script, :enable_static_analyzer, :indentation_level, :warnings, :application_target_groups, :unit_test_target_groups, :use_cocoapods, :strict_prompts | |||
|
Can you rebase #128 onto master and include these changes, and we'll treat it as one PR? |
…utes with no specified default value
|
Combined with #128 and rebased against master. |
| @@ -30,6 +30,10 @@ def global_options | |||
| exit | |||
| end | |||
|
|
|||
| opts.on('--[no-]strict-prompts', 'Enable/Disable strict prompts') do |strict_prompts| | |||
There was a problem hiding this comment.
Does this work? I thought we couldn't have hyphens in the flag? Or was that just for flags that take a value?
There was a problem hiding this comment.
Yes, it works for flags that already have a modifier. That's why it works for --[no-]strict-prompts but not for --indentation-level. optparse has some pretty eccentric parsing logic.
| rescue EOFError | ||
| puts | ||
| fetch_option_for(attribute, prompt) | ||
| rescue Interrupt | ||
| exit 1 | ||
| end | ||
|
|
||
| def prompt_for_default?(default) | ||
| !default || !@configuration.strict_prompts |
There was a problem hiding this comment.
This still bugs me, sorry. Talked it over with some ruby folks, and we kind of settled on flipping this conditional and using unless on line 18:
def skip_prompt?(default)
default && @configuration.strict_prompts
endMy brain doesn't do as many backflips with it written out this way.
|
Fantastic. Rebased/Squashed/Merged as c6a05f8. Thanks! |
|
Yay! |
This is especially useful when used with CLI config overrides (#126).
As an example, suppose you have the following
.liftoffrc:and you run liftoff, you'l only be prompted for the project name before the project gets created.
I have another incoming PR that combines this with #126 by adding a CLI option
--strict-prompts, making this infinitely more useful because it allows doing this:liftoff -n ProjName --strict-promptsand you don't get prompted at all.