Add the ability to specify arbitrary templates #147
Conversation
|
I need to add documentation to this before merging. |
| module Liftoff | ||
| class TemplateGenerator | ||
| def generate_templates(config, file_manager) | ||
| if config.templates |
There was a problem hiding this comment.
What do you think about having config.templates default to {}, so we don't need this conditional?
There was a problem hiding this comment.
Users can override this value in their own config files, so leaving the conditional out is potentially unsafe.
There was a problem hiding this comment.
How would it be unsafe?
def templates
@templates || {}
endwould return {} in all cases where this conditional would have returned false, and each_pair on an empty hash is a noop.
There was a problem hiding this comment.
Ah, I see what you mean. I thought you meant default in the config.
I might do this as a part of another PR. Right now, we're using this pattern pretty consistently, and it might be good to try to do this across the board.
This adds the ability to define a `templates` key in your `liftoffrc`. The value for this key should be an array of key/value pairs in the format of: <template name>: <destination relative to project root> We'll add a real default for this key soon, but I'd just like to make sure this isn't nil for now.
This adds the ability to define a
templateskey in yourliftoffrc. Thevalue for this key should be an array of key/value pairs in the format of:
<template name>: <destination relative to project root>Fixes #146