-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to change the unit test target name #187
Conversation
This looks great. I'm wracking my brain trying to figure out if this is going to cause any issues, but I can't think of any. Makes me wonder why I didn't do this a while ago. Can you rebase on master and remove the part where you pass the config to the CocoaPods setup stuff? That got merged in with #189 just now. After that I can get this into master. |
db5877e
to
49dc664
Compare
Thanks @gfontenot. All rebased and tested! |
@@ -5,7 +5,7 @@ platform :ios, '<%= deployment_target %>' | |||
# Add Application pods here | |||
|
|||
target :unit_tests, :exclusive => true do | |||
link_with 'UnitTests' | |||
link_with '<%= project_name %>' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be test_target_name
Maybe we should also let users set this value via prompt when they generate the project like we do with the project name, prefix, etc? |
49dc664
to
ac7fa30
Compare
I've fixed that error (good spot) and added support for setting the test target name via the prompt 👍 |
Rad. Merged in 751a08e. Thanks! |
Thanks @gfontenot! |
Added the ability to specify an alternative name for the unit test target, as suggested by #169. The default is still
UnitTests
to match the previous output.I also fixed an issue where the project configuration was not being passed to the
FileManager
'sgenerate
method, because theCocoapodsSetup
had not been given access to it.Thanks for the brilliant tool. I'll be using it to setup my iOS projects from now on! 👍