Let users add arbitrary configuration to tests #213
Merged
+58
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `extra_test_config` key to the `liftoffrc`. This key acts similarly to the `extra_config` key, but adds arbitrary configuration to the test target. If more than one test target exists, the user will be given the chance to select the target they would like to modify.
| end | ||
| def perform_extra_config(app_config, test_config) | ||
| [app_config, test_config].each do |config| | ||
| if config |
There was a problem hiding this comment.
You could do .compact.each to remove this if statement. .compact removes nils.
I'm a dummy and this didn't actually work before. Now it does. Huzzah!
| @@ -7,6 +7,12 @@ def []=(key, value) | |||
| configuration.build_settings[key] = value | |||
| end | |||
| end | |||
|
|
|||
| def merge!(hash) | |||
|
@gabebw I'm going to merge this unless you had any other comments. |
| if config | ||
| config.each do |name, settings| | ||
| if name.downcase == "all" | ||
| object = target |
There was a problem hiding this comment.
Should this now be application_target?
There was a problem hiding this comment.
Nope, it's whatever target we've associated with the config on line 56.
|
👍 |
|
merged as a159489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
extra_test_configkey to theliftoffrc. This key actssimilarly to the
extra_configkey, but adds arbitrary configuration to thetest target. If more than one test target exists, the user will be given the
chance to select the target they would like to modify.
Fixes #193