fix: Register grpc reflection service in Init (#1519)

* fix: Register grpc reflection service in Init

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Update grpc

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Add WithReflection option as opt-out

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

plugins/orchestrator/options.go

@@ -31,6 +31,7 @@ func NewPlugin(opts ...Option) *Plugin {
 	p.GRPC = &grpc.DefaultPlugin
 	p.KVScheduler = &kvscheduler.DefaultPlugin
 	p.Watcher = local.DefaultRegistry
+	p.reflection = true
 
 	for _, o := range opts {
 		o(p)
@@ -42,3 +43,9 @@ func NewPlugin(opts ...Option) *Plugin {
 
 // Option is a function that acts on a Plugin to inject Dependencies or configuration
 type Option func(*Plugin)
+
+func WithReflection(enabled bool) Option {
+	return func(p *Plugin) {
+		p.reflection = enabled
+	}
+}

plugins/orchestrator/orchestrator.go

@@ -49,6 +49,8 @@ type Plugin struct {
 	resyncChan   chan datasync.ResyncEvent
 	watchDataReg datasync.WatchRegistration
 
+	reflection bool
+
 	*dispatcher
 }
 
@@ -79,6 +81,11 @@ func (p *Plugin) Init() (err error) {
 	if grpcServer := p.GRPC.GetServer(); grpcServer != nil {
 		generic.RegisterManagerServer(grpcServer, p.manager)
 		generic.RegisterMetaServiceServer(grpcServer, p.manager)
+		// register grpc services for reflection
+		if p.reflection {
+			p.Log.Infof("registering grpc reflection service")
+			reflection.Register(grpcServer)
+		}
 	} else {
 		p.log.Infof("grpc server not available")
 	}
@@ -117,9 +124,6 @@ func (p *Plugin) AfterInit() (err error) {
 	p.kvs.WatchValueStatus(statusChan, nil)
 	go p.watchStatus(statusChan)
 
-	// register grpc services for reflection
-	reflection.Register(p.GRPC.GetServer())
-
 	return nil
 }