Error deploying project because dbt model names in a manifest.json are not always unique

[owlas]

Description

Lightdash assumes that dbt model names are unique. This was true until this PR was merged: dbt-labs/dbt-core#7374 - with this change, Project A can have model users and also have a dependency on Project B with a model called users

The resulting manifest will have two models with the name users but they'll have different unique ids model.project_a.users and model.project_b.users

When this happens, Lightdash throws an error when deploying a project project.

[TuringLovesDeathMetal]

There is also versioning models in dbt which causes this issue! https://docs.getdbt.com/docs/collaborate/govern/model-versions#how-to-create-a-new-version-of-a-model

[TuringLovesDeathMetal]

We should potentially make the unique ID a different thing than the name (before, teh name used to be unique, but now it's not anymore - we should update the model's unique ID to be something other than the name. E.g. project.model_name)

[ZeRego]

In this PR I'm avoiding this error by discarding/ignoring models with duplicate names. It will only use the first model for each name.

This fix is focused on not throwing an error to unblock users that deploy their project via the UI which deploys all their models. We can open a new ticket to support multiple models with the same name.

[lightdash-bot]

🎉 This issue has been resolved in version 0.921.2 🎉

The release is available on:

• 0.921.2
• GitHub release

Your semantic-release bot 📦🚀