-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BOLT 7: gossip_status
(feature 66/67)
#1186
Conversation
This is a simple sync message, so vastly out-of-sync nodes can be handed the gossip they need. It's a stopgap until gossip v2. I'll be implementing this (as feature 100+66/67, and message 32768+267) for testing. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1. Suggest simply sending it after initial gossip_timestamp_filter. 2. Explicitly allow generic gossip dump in reply (how I implemented it for now) 3. End all requirements with periods for consistency
This activates the logic, by enabling the feature bit. Changelog-EXPERIMENTAL: Protocol: `gossip_status` support (lightning/bolts#1186) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This activates the logic, by enabling the feature bit. Changelog-EXPERIMENTAL: Protocol: `gossip_status` support (lightning/bolts#1186) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
At a spec level it seems query messages should already provide this functionality. Do implementations other than CLN encounter issues with the current query mechanism? Perhaps it would be quicker to fix any implementation bugs with the existing mechanism rather than create a whole new spec that not all implementations may implement any time soon (or ever). |
This activates the logic, by enabling the feature bit. Changelog-EXPERIMENTAL: Protocol: `gossip_status` support (lightning/bolts#1186) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Well, LDK kind of gave up and just asks for all the gossip. This is gentler. Not sure what the status of LND is, but without something like this you can't even know if there's stuff you don't know. If someone wants to write up a good way of doing this, I'd be delighted! With gossipv2 it's possible to use set reconciliation, but there's a lot of work needed to do that, so this is a simple bandaid in the meantime. |
This activates the logic, by enabling the feature bit. Changelog-EXPERIMENTAL: Protocol: `gossip_status` support (lightning/bolts#1186) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This activates the logic, by enabling the feature bit. Changelog-EXPERIMENTAL: Protocol: `gossip_status` support (lightning/bolts#1186) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Isn't this what extended gossip queries are for? You send a series of |
Dropping this due to lack of enthusiasm, and other ways of implementing. |
This is a simple sync message, so vastly out-of-sync nodes can be handed the gossip they need. It's a stopgap until gossip v2.
I'll be implementing this (as feature 100+66/67, and message 30000+267) for testing.