Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 7: gossip_status (feature 66/67) #1186

Closed
wants to merge 2 commits into from

Conversation

rustyrussell
Copy link
Collaborator

@rustyrussell rustyrussell commented Jul 28, 2024

This is a simple sync message, so vastly out-of-sync nodes can be handed the gossip they need. It's a stopgap until gossip v2.

I'll be implementing this (as feature 100+66/67, and message 30000+267) for testing.

This is a simple sync message, so vastly out-of-sync nodes can be handed the
gossip they need.  It's a stopgap until gossip v2.

I'll be implementing this (as feature 100+66/67, and message 32768+267)
for testing.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell requested a review from t-bast July 28, 2024 05:59
1. Suggest simply sending it after initial gossip_timestamp_filter.
2. Explicitly allow generic gossip dump in reply (how I implemented it for now)
3. End all requirements with periods for consistency
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Jul 29, 2024
This activates the logic, by enabling the feature bit.

Changelog-EXPERIMENTAL: Protocol: `gossip_status` support (lightning/bolts#1186)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Jul 29, 2024
This activates the logic, by enabling the feature bit.

Changelog-EXPERIMENTAL: Protocol: `gossip_status` support (lightning/bolts#1186)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@morehouse
Copy link
Contributor

At a spec level it seems query messages should already provide this functionality.

Do implementations other than CLN encounter issues with the current query mechanism? Perhaps it would be quicker to fix any implementation bugs with the existing mechanism rather than create a whole new spec that not all implementations may implement any time soon (or ever).

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Jul 31, 2024
This activates the logic, by enabling the feature bit.

Changelog-EXPERIMENTAL: Protocol: `gossip_status` support (lightning/bolts#1186)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
Copy link
Collaborator Author

Well, LDK kind of gave up and just asks for all the gossip. This is gentler. Not sure what the status of LND is, but without something like this you can't even know if there's stuff you don't know. If someone wants to write up a good way of doing this, I'd be delighted!

With gossipv2 it's possible to use set reconciliation, but there's a lot of work needed to do that, so this is a simple bandaid in the meantime.

rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Aug 5, 2024
This activates the logic, by enabling the feature bit.

Changelog-EXPERIMENTAL: Protocol: `gossip_status` support (lightning/bolts#1186)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Aug 5, 2024
This activates the logic, by enabling the feature bit.

Changelog-EXPERIMENTAL: Protocol: `gossip_status` support (lightning/bolts#1186)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@morehouse
Copy link
Contributor

Isn't this what extended gossip queries are for?

You send a series of query_channel_range messages with the timestamp bit set, checking the replies against your channel_update timestamps. Then you can request the specific channel_updates you're missing.

@rustyrussell
Copy link
Collaborator Author

Dropping this due to lack of enthusiasm, and other ways of implementing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants