Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channeldb+invoices: add spontaneous AMP receiving + sending via SendToRoute #5108

Merged
merged 22 commits into from
Apr 7, 2021
Merged

channeldb+invoices: add spontaneous AMP receiving + sending via SendToRoute #5108

merged 22 commits into from
Apr 7, 2021

Commits on Apr 7, 2021

  1. record: convert child_index from uint16 to uint32

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    8fe4de8 View commit details
    Browse the repository at this point in the history

  2. record/amp: use switch from 10 -> 14 for AMP TLV type 

    This is to not conflict with trampoline BOLT.
    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    82b4f11 View commit details
    Browse the repository at this point in the history

  3. htlcswitch/hop: make unknown required type const 

    Currently we use the AMP record type, this allows us to change it easily
as we add new known records. We also bump this to 0x0c instead of 0x0a.
    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    135a0a9 View commit details
    Browse the repository at this point in the history

  4. htlcswitch/hop: parse and validate AMP records

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    c2729cb View commit details
    Browse the repository at this point in the history

  5. features: define temporary AMP feature bits 30/31

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    438b03a View commit details
    Browse the repository at this point in the history

  6. channeldb/invoice: add InvoiceRefByAddr

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    be66984 View commit details
    Browse the repository at this point in the history

  7. channeldb: make payhash on InvoiceRef optional 

    Currently we support queries by payHash or payHash+payAddr. For handling
of AMP HTLCs, we only need to support querying by payAddr.
    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    174d577 View commit details
    Browse the repository at this point in the history

  8. channeldb: refactor InvoiceRef.String() with all optional fields

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    7bed359 View commit details
    Browse the repository at this point in the history

  9. channeldb: validate feature dependencies when adding invoice

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    7e2f5a1 View commit details
    Browse the repository at this point in the history

  10. invoices: add checkSettleResolution and checkFailResolution 

    Also refactor existing unit tests to use them.
    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    3fb70dd View commit details
    Browse the repository at this point in the history

  11. invoices: add processAMP

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    88b72ab View commit details
    Browse the repository at this point in the history

  12. channeldb/invoice_test: only set htlc-level preimage on accept

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    24d283e View commit details
    Browse the repository at this point in the history

  13. channeldb/invoices: set AMP HTLC preimages when settling invoice

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    6780f74 View commit details
    Browse the repository at this point in the history

  14. channeldb/invoice: make Copy() a member of InvoiceHTLC

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    0b5be85 View commit details
    Browse the repository at this point in the history

  15. channeldb/invoices: rigorously test updateHtlc for MPP/AMP scenarios

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    2a49b59 View commit details
    Browse the repository at this point in the history

  16. invoices: reconstruct AMP child preimages

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    90a2550 View commit details
    Browse the repository at this point in the history

  17. invoices: add TestSpontaneousAmpPayment 

    Adds a set of test cases that exercise the spontaneous AMP payment flow
with valid and invalid reconstructions, as well as with single and
multiple HTLCs. This also asserts that spontaneous AMP is gated behind
the existing AcceptKeysend flag.
    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    ea934e1 View commit details
    Browse the repository at this point in the history

  18. channeldb/invoice: allow creating AMP invoices w/o preiamge

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    cfa9e95 View commit details
    Browse the repository at this point in the history

  19. lnrpc: add AMPRecord to Hop

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    00581ef View commit details
    Browse the repository at this point in the history

  20. lnrpc: add UnmarshalAMP decoding

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    352ce10 View commit details
    Browse the repository at this point in the history

  21. lntest: make buildRoute method on mppTestContext 

    This will be reused by the amp itest.
    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    888af51 View commit details
    Browse the repository at this point in the history

  22. lntest: add AMP itest

    @cfromknecht
    cfromknecht committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    730b718 View commit details
    Browse the repository at this point in the history