Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zpay32: Change min_final_cltv_expiry_delta. #8308

Merged
merged 2 commits into from
Jan 2, 2024
Merged

zpay32: Change min_final_cltv_expiry_delta. #8308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec02ffa
zpay32: Change min_final_cltv_expiry_delta.
ziggie1984 Dec 22, 2023
160713e
docs: add release-notes.
ziggie1984 Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/release-notes/release-notes-0.18.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,13 @@
be switched off using the new `protocol.no-timestamp-query-option` config
option.

* [Update min_final_cltv_expiry_delta](https://github.com/lightningnetwork/lnd/pull/8308).
This only effects external invoices which do not supply the
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, just noticed a typo while writing the Optech mention for this PR:

Suggested change
This only effects external invoices which do not supply the
This only affects external invoices which do not supply the

min_final_cltv_expiry parameter. LND has NOT allowed the creation of invoices
with a lower min_final_cltv_expiry_delta value than 18 blocks since
LND 0.11.0.


## Testing

* Added fuzz tests for [onion
Expand Down
5 changes: 4 additions & 1 deletion zpay32/hophint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ const (
// DefaultAssumedFinalCLTVDelta is the default value to be used as the
// final CLTV delta for a route if one is unspecified in the payment
// request.
DefaultAssumedFinalCLTVDelta = 9
// We adhere to the recommendation in BOLT 02 for terminal payments.
// See also:
// https://github.com/lightning/bolts/blob/master/02-peer-protocol.md
DefaultAssumedFinalCLTVDelta = 18
)

// HopHint is a routing hint that contains the minimum information of a channel
Expand Down
Loading