Beat itest [2/3]: document and fix itest flakes #9307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Pull reviewers statsStats of the last 30 days for lnd:
|
yyforyongyu
force-pushed
the
yy-beat-itest-flakes
branch
from
b1011ac to
d8d2a54
Compare
guggero
approved these changes
Dec 2, 2024
yyforyongyu
force-pushed
the
yy-beat-itest-shuffle
branch
from
c6819c0 to
3c60868
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-flakes
branch
2 times, most recently
from
a558fe3 to
3ac3b53
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-shuffle
branch
from
3c60868 to
abda3ce
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-flakes
branch
from
3ac3b53 to
8abca8c
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-shuffle
branch
from
abda3ce to
21082c5
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-flakes
branch
from
8abca8c to
6f59050
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-shuffle
branch
from
21082c5 to
9374711
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-flakes
branch
from
6f59050 to
9c24fc0
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-shuffle
branch
from
9374711 to
e7beb0a
Compare
So it's easier to get the logs and debug.
We previously didn't see this issue because we always have nodes being over-funded.
So we know which open channel operation failed.
We need to mine an empty block as the tx may already have entered the mempool. This should be fixed once we start using the sweeper to handle the justice tx.
The reconnection will happen automatically when the nodes have a channel, so we just ensure the connection instead of reconnecting directly.
So we won't forget to assert the topology after opening a chain of channels.
This is no longer needed since we don't have standby nodes, plus it's causing panic in windows build due to `edge.Policy` being nil.
This has been seen in the itest which can lead to the node startup failure, ``` 2024-11-20 18:55:15.727 [INF] RPCS: Max websocket clients exceeded [25] - disconnecting client 127.0.0.1:57224 ```
This is needed so we can have one place to fix the flakes found in the MPP-related tests, which is fixed in the following commit.
We now make sure the channel participants have heard their private channel when opening channels.
yyforyongyu
force-pushed
the
yy-beat-itest-flakes
branch
from
9c24fc0 to
a6b616e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check #9306 for context, and #9260 for the final result.
Changes in each commit is pretty small, major changes are,
flatten some tests so it's easier to debug.
We encountered issue [bug]: listunspent shows spent outputs #8786 - which should have been caught way easier if we didn't use the standby nodes, and is now temporarily hacked. This will be my high-priority item to fix.
when checking for the sweeping tx, if the tx is RBFed, the old txid won't work.
connect to an already connected node can result in an error.
increase payment timeout for sql.
assert channel is in the grapb before sending payments.
assert outgoing and incoming HTLCs separately.
increase
rpcmaxwebsocketsforbtcd.document the MPP flake - we now have a much better understanding of how it happened.
some other minor refactors.