Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed models from "Kitchen" scene. #24

Closed
fynv opened this issue Sep 20, 2022 · 6 comments
Closed

Failed models from "Kitchen" scene. #24

fynv opened this issue Sep 20, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@fynv
Copy link

fynv commented Sep 20, 2022

geo.zip

Uploading 2 of the models tinyusdz currently cannot parse.

Not sure if these are because of compositions. These models are the leaf nodes of reference chains.
Is it because of missing information from the referencing context so we cannot parse them separately?

@syoyo
Copy link
Collaborator

syoyo commented Sep 20, 2022

Therse files contains VariantSelectionMap which is a composition feature and not yet supported in TinyUSDZ.

tinyusdz/src/crate-reader.cc:UnpackValueRep():2987 Invalid data type(or maybe not supported in TinyUSDZ yet) for Inlined value: VariantSelectionMap

I may try to accept it as a workaround(do parsing, but do nothing and print warnings)

@fynv
Copy link
Author

fynv commented Sep 20, 2022

Just wondering, for USDC->USDA, is it possible to do without fully loading the stage?
Could be very helpful to look at the content of a USDC file.

@syoyo
Copy link
Collaborator

syoyo commented Sep 20, 2022

@fynv USDC itself allow delayed load of content. TinyUSDZ currently fully load content in parsing. Delayed loading is related to Compositions so TinyUSDZ may support delayed loading feature once compositions feature has been implemented(not so soon).

@syoyo
Copy link
Collaborator

syoyo commented Sep 20, 2022

Skip parsing composition arcs data in this commit: a913213

At least it loads without error. Composition arcs feature(e.g. over specifier) are missing in reconstructed Stage data.

@fynv
Copy link
Author

fynv commented Sep 20, 2022

Yes, I'm able to load the mesh data from "Book" now.
Thanks! We can close this now, or not, if you prefer to keep tracking.

@syoyo
Copy link
Collaborator

syoyo commented Sep 20, 2022

I'm able to load the mesh data from "Book" now.

Good!

I'll plan to keep compositions feature here #25

@syoyo syoyo closed this as completed Sep 20, 2022
@syoyo syoyo added the enhancement New feature or request label Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants