Skip to content

Commit

Permalink
Fix extension of js/Symbol in favour of primitive (#147)
Browse files Browse the repository at this point in the history 
Fixes warning on ClojureScript master

Co-authored-by: Dominic Monroe <dominic@dominic.io>
  • Loading branch information
@SevereOverfl0w
SevereOverfl0w and Dominic Monroe authored Jan 30, 2024
1 parent 9b27555 commit 35127b7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/helix/core.cljs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
(:require-macros [helix.core]))


(when (exists? js/Symbol)
(when (exists? symbol)

This comment has been minimized.

Sign in to view

Copy link
@thheller

thheller Mar 19, 2024

This should have stayed js/Symbol, as symbol is only valid for extend-protocol.
(extend-protocol IPrintWithWriter
js/Symbol
symbol
(-pr-writer [sym writer _]
(-write writer (str "\"" (.toString sym) "\"")))))

Expand Down

0 comments on commit 35127b7

Please sign in to comment.