-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmic freezes when one opens Firefox #335
Comments
I'm having this issue on my AMD Framework Laptop, but not on my desktop that also uses AMD graphics. |
Can someone share the |
@lilyinstarlight how exactly am i supposed to use journalctl? |
➜ ~ journalctl -b --priority=3 |
More info that I found after some tinkering just now:
|
good info! I can also confirm that it seems to occur with most Firefox forks. Here's my journalctl output as well: https://gist.github.com/michaelBelsanti/379566d70ac73d6b048c5d7d3fea5b9a |
this patch has fixed it for me pop-os/cosmic-comp#887 (comment) |
How do I apply that patch? |
Something like this in your nixos config: EDIT: See below, do not use this patch any longer nixpkgs.overlays = [
(final: prev: {
cosmic-comp = prev.cosmic-comp.overrideAttrs (prevAttrs: {
patches = (prevAttrs.patches or []) ++ [
(pkgs.writeText "cosmic-comp-disable-direct-scanout.patch" ''
diff --git a/src/backend/kms/surface/mod.rs b/src/backend/kms/surface/mod.rs
index d0cfb8d..32aaf4a 100644
--- a/src/backend/kms/surface/mod.rs
+++ b/src/backend/kms/surface/mod.rs
@@ -624,7 +624,8 @@ impl SurfaceThreadState {
cursor_size,
Some(gbm),
) {
- Ok(compositor) => {
+ Ok(mut compositor) => {
+ compositor.use_direct_scanout(false);
self.active.store(true, Ordering::SeqCst);
self.compositor = Some(compositor);
Ok(())
'')
];
});
})
]; (Though to be clear, this patch doesn't "fix" anything. It just avoids a broken amdgpu driver codepath) |
I am not sure if this deserves a different issue or not. But for me I just get really bad performance when firefox is open, many small freezes. Nothing up to 30 seconds but up to about 10 seconds max at a time where I can't use the system at all. cosmic-comp goes to the top of my cpu usage whenever trying to do anything in firefox. But in something like chrome everything is fine. Just mousing the cursor over the firefox window (not maximized, or maximized, doesn't matter) causes the spikes and unresponsiveness. I added the overlay above but that did not change anything for me: Note that this system is Intel CPU and intel iris xe graphics |
My side, after patching as per the suggestion above, the firefox lock-ups went away. That said, after the latest cosmic updates and 6.11.2 (NixOS unstable), I was able to remove the overlay and the issue seems to have gone away. @RingOfStorms I think the overlay shared is only going to apply to AMD GPU's (amdgpu). |
@RingOfStorms Yeah that sounds unrelated. Your issue is more likely related to pop-os/cosmic-comp#749/pop-os/cosmic-comp#703 if you are using client-side decorations in firefox |
Thanks, it actually ended up being this one: I had no wallpaper/bg set... It now works fine, wild that background can affect anything else like that |
Oh yeah that sounds like a bug in cosmic-comp... I was gonna fix default wallpapers very soon, it just needs some XDG_DATA_DIRS plumbing upstream. But lacking a wallpaper shouldn't be doing that regardless |
For those using the above patch, please now use |
No description provided.
The text was updated successfully, but these errors were encountered: