You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Not sure it matters much, but maybe go with v4 to make it obvious it is a fork. Given that upstream didn't have a release in almost a year, they might never move beyond v3.
I assume we would then also create our own releases from the fork, to avoid linking to a specific commit in go.mod?
Version 1 should be avoided so as to keep monotonicity.
I don't think even that matters, as it is just a package name, but numbers are cheap... 😄
Same as Jan, since the base module name (github.com/lima-vm/vz) changes, I don't think anyone is going to make any assumptions about API/ABI compatibility. I think you could even start back without any versioning. vz/v3 would emphasize it's fully compatible with Code-Hex/vz/v3, vz/v4 may give a hint that it's a fork, but people could also wonder where the API changes are (?).
So as to remove
replace()
:https://github.com/lima-vm/lima/blob/f1babc0ee4c38fc10ff6612ff4bf3acc42fa2dee/go.mod#L145
Not sure if the version should be 3 or 4.
Version 1 should be avoided so as to keep monotonicity.
The text was updated successfully, but these errors were encountered: