Skip to content

Latest commit

 

History

History
98 lines (64 loc) · 3.14 KB

CONTRIBUTING.md

File metadata and controls

98 lines (64 loc) · 3.14 KB
Raw

Contributing

Contributions are welcome, and they are greatly appreciated! Every little bit helps, and credit will always be given.

You can contribute in many ways:

Types of Contributions

Report Bugs

Report bugs at https://github.com/Noble-Lab/ms_imputer/issues.

If you are reporting a bug, please include:

  • Your operating system name and version.
  • Any details about your local setup that might be helpful in troubleshooting.
  • Detailed steps to reproduce the bug.

Fix Bugs

Look through the GitHub issues for bugs. Anything tagged with "bug" and "help wanted" is open to whoever wants to implement it.

Implement Features

Look through the GitHub issues for features. Anything tagged with "enhancement" and "help wanted" is open to whoever wants to implement it.

Write Documentation

ms_imputer could always use more documentation, whether as part of the official ms_imputer docs, in docstrings, or even on the web in blog posts, articles, and such.

Submit Feedback

The best way to send feedback is to file an issue at https://github.com/Noble-Lab/ms_imputer/issues.

If you are proposing a feature:

  • Explain in detail how it would work.
  • Keep the scope as narrow as possible, to make it easier to implement.
  • Remember that this is a volunteer-driven project, and that contributions are welcome :)

Get Started!

Ready to contribute? Here's how to set up ms_imputer for local development.

  1. Fork the ms_imputer repo on GitHub: https://github.com/Noble-Lab/ms_imputer

  2. Clone your fork locally:

    $ git clone https://github.com/your-name/ms_imputer.git

  3. Install your local copy into a virtualenv. Using the standard library venv module:

    $ cd ms_imputer
$ python3 -m venv ms_imputer-dev
$ source ms_imputer-dev/bin/activate
$ pip3 install -r requirements.txt -r test_requirements.txt -e .

  4. Create a branch for local development:

    $ git checkout -b name-of-your-bugfix-or-feature

    Now you can make your changes locally.

  5. When you're done making changes, check that your changes pass flake8 and pytest:

    $ make test
$ make coverage
$ make lint

  6. Commit your changes and push your branch to GitHub:

    $ git add .
$ git commit -m "Your detailed description of your changes."
$ git push origin name-of-your-bugfix-or-feature

  7. Submit a pull request through the GitHub website. See CONTRIBUTING.md for more.

Pull Request Guidelines

Before you submit a pull request, check that it meets these guidelines:

  1. The pull request should include tests.
  2. If the pull request adds functionality, the docs should be updated. Put your new functionality into a function with a docstring, and add the feature to the list in README.rst.
  3. The pull request should work for Python 3.5, 3.6, 3.7 and 3.8, and for PyPy. Check https://travis-ci.com/Noble-Lab/ms_imputer/pull_requests and make sure that the tests pass for all supported Python versions.