Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row Offset for 16x4 lcd is wrong #15

Closed
TilTisback opened this issue Jun 23, 2019 · 2 comments
Closed

Row Offset for 16x4 lcd is wrong #15

TilTisback opened this issue Jun 23, 2019 · 2 comments

Comments

@TilTisback
Copy link

Hello,

the row offset in "LiquidTWI2.cpp" line 347 is wrong.

int row_offsets[] = { 0x00, 0x40, 0x14, 0x54 };

when you compile it with a 16x4 LCD you get this: (im just filling all the characters with 0-15 in hex)
photo_2019-06-23_22-40-32

when you change the row offset to
int row_offsets[] = { 0x00, 0x40, 0x10, 0x50 };
you get this like expected:
photo_2019-06-23_22-40-38

i think noone has found this bug yet, because i am using a 16x4 LCD instead of a 16x2 LCD.

@lincomatic
Copy link
Owner

Thank you.

070881f

@FixyNeko
Copy link

this fix is wrong, it only transfer the problem that was on the 16x4 screen to the 20x4 ones. There should be 2 distinct offset based on the width of the lcd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants