Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add error message in GetByteCode() #742

Merged
merged 5 commits into from
Oct 24, 2022

Conversation

da1suk8
Copy link
Member

@da1suk8 da1suk8 commented Oct 19, 2022

Description

I added error message in GetByteCode().

Motivation and context

An error occurred in GetByteCode, but the error is not returned.

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@da1suk8 da1suk8 self-assigned this Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #742 (d3bc33e) into main (1e53873) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   62.05%   62.04%   -0.01%     
==========================================
  Files         877      877              
  Lines       98977    98977              
==========================================
- Hits        61416    61412       -4     
- Misses      33944    33949       +5     
+ Partials     3617     3616       -1     
Impacted Files Coverage Δ
store/types/store.go 56.25% <ø> (ø)
x/wasm/keeper/keeper.go 86.16% <100.00%> (ø)
x/token/msgs.go 32.48% <0.00%> (-4.07%) ⬇️
x/token/validation.go 70.90% <0.00%> (-1.82%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️
x/collection/msgs.go 39.44% <0.00%> (+1.11%) ⬆️

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add changelog.

x/wasm/keeper/keeper.go Show resolved Hide resolved
@da1suk8 da1suk8 marked this pull request as ready for review October 21, 2022 10:02
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@da1suk8 da1suk8 merged commit 1726293 into Finschia:main Oct 24, 2022
@da1suk8 da1suk8 deleted the fix/add_error_message branch October 24, 2022 02:15
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants