Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register missing amino codec of x/token, x/collection, x/wasm and x/foundation #745

Merged
merged 15 commits into from
Oct 25, 2022
Merged

Register missing amino codec of x/token, x/collection, x/wasm and x/foundation #745

merged 15 commits into from
Oct 25, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Oct 20, 2022 •
edited
Loading

Description

Add missing amino codec of x/token, x/collection, x/wasm and x/foundation.
This PR related with #736.

closes: #735

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue
fix: implement Amino serialization for x/token
d79fdfd 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue
fix: implement Amino serialization for x/collection
b8ba54f 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue
fix: implement Amino serialization for x/foundation, x/stakingplus
42b58a8 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue
fix: conflict msgs
4bac217 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue
fix: change x/wasm amino to using legacyCdc
0696821 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue
fix: change conflict amino msgName with x/token and x/collection.
eeb032d 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@codecov
Copy link

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

Merging #745 (45071dd) into main (1726293) will increase coverage by 0.09%.
The diff coverage is 82.10%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
+ Coverage   62.06%   62.16%   +0.09%     
==========================================
  Files         877      879       +2     
  Lines       98977    99371     +394     
==========================================
+ Hits        61432    61771     +339     
- Misses      33927    33972      +45     
- Partials     3618     3628      +10
Impacted Files Coverage Δ
x/foundation/msgs.go 71.47% <15.38%> (-15.28%) ⬇️
x/token/codec.go 56.75% <91.30%> (+56.75%) ⬆️
x/collection/codec.go 43.83% <100.00%> (+43.83%) ⬆️
x/collection/msgs.go 55.05% <100.00%> (+16.72%) ⬆️
x/foundation/codec.go 50.00% <100.00%> (+50.00%) ⬆️
x/stakingplus/codec.go 64.28% <100.00%> (ø)
x/token/msgs.go 47.90% <100.00%> (+7.29%) ⬆️
x/wasm/lbmtypes/codec.go 51.85% <100.00%> (ø)
x/wasm/types/codec.go 100.00% <100.00%> (ø)
... and 8 more

@zemyblue
chore: add more unittest
b27e4ea 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue
chore: update changelog
d8fdde2 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue self-assigned this Oct 20, 2022
ulbqb
ulbqb reviewed Oct 21, 2022
View reviewed changes
Copy link
Member

@ulbqb ulbqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found redundant code.

x/token/msgs_test.go Show resolved Hide resolved
@zemyblue
chore: remove redundant code.
29c0ce1 
Signed-off-by: zemyblue <zemyblue@gmail.com>
0Tech
0Tech reviewed Oct 21, 2022
View reviewed changes
x/foundation/codec.go Show resolved Hide resolved
x/foundation/codec.go Show resolved Hide resolved
x/foundation/msgs_test.go Outdated Show resolved Hide resolved
@zemyblue
fix: apply feedback.
1967603 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@ulbqb ulbqb self-requested a review October 24, 2022 02:49
ulbqb
ulbqb approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@ulbqb ulbqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech self-requested a review October 24, 2022 04:10
0Tech
0Tech reviewed Oct 24, 2022
View reviewed changes
x/collection/codec.go Outdated Show resolved Hide resolved
@zemyblue
fix: remove unused amino codec type, Change of x/collection
65f4747 
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue requested a review from 0Tech October 24, 2022 10:14
@zemyblue
fix: remove unused amino codec type, MintNFTParam of x/collection
45071dd 
Signed-off-by: zemyblue <zemyblue@gmail.com>
0Tech
0Tech approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue merged commit f7d1830 into Finschia:main Oct 25, 2022
@zemyblue zemyblue deleted the missing_aminojson branch October 25, 2022 02:53
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
Merged
5 tasks
@0Tech 0Tech mentioned this pull request Oct 27, 2022
Merged
3 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulbqb ulbqb ulbqb approved these changes

@0Tech 0Tech 0Tech approved these changes

@dudong2 dudong2 Awaiting requested review from dudong2

@tkxkd0159 tkxkd0159 Awaiting requested review from tkxkd0159 tkxkd0159 is a code owner

Assignees

@zemyblue zemyblue

Labels
C:WASM C:x/collection C:x/foundation x/foundation module C:x/token
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Register legacy amino codec for support the ledger device
3 participants
@zemyblue @0Tech @ulbqb