-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change to create chCheckTx
with the value set in app config.
#756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
zemyblue
changed the title
feat: add chCheckTxSize configuration of Baseapp
Change to create Oct 25, 2022
chCheckTx
with the value set in app config.
Signed-off-by: zemyblue <zemyblue@gmail.com>
zemyblue
changed the title
Change to create
feat: change to create Oct 25, 2022
chCheckTx
with the value set in app config.chCheckTx
with the value set in app config.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
+ Coverage 62.15% 62.16% +0.01%
==========================================
Files 879 879
Lines 99371 99385 +14
==========================================
+ Hits 61760 61787 +27
+ Misses 33991 33975 -16
- Partials 3620 3623 +3
|
dudong2
approved these changes
Oct 25, 2022
tkxkd0159
reviewed
Oct 26, 2022
Signed-off-by: zemyblue <zemyblue@gmail.com>
tkxkd0159
approved these changes
Oct 26, 2022
0Tech
reviewed
Oct 26, 2022
Signed-off-by: zemyblue <zemyblue@gmail.com>
0Tech
approved these changes
Oct 26, 2022
3 tasks
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change to create
chCheckTx
with the value set in app config.Basically,
chCheckTx
of BaseApp should be equals to or greater than mempool size.But when running NewBaseApp, the mempool size can not know.
So I add the feature set the size of
chCheckTx
as configSo following features have been changed
chCheckTxSize
in BaseappFlagChanCheckTxSize
flag as cmd flagchan-check-tx-size
field in app config.chanCheckTxSize
to 10000.closes: #753
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml