Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change to create chCheckTx with the value set in app config. #756

Merged
merged 5 commits into from
Oct 26, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Oct 25, 2022

Description

Change to create chCheckTx with the value set in app config.

Basically, chCheckTx of BaseApp should be equals to or greater than mempool size.
But when running NewBaseApp, the mempool size can not know.
So I add the feature set the size of chCheckTx as config

So following features have been changed

  • add chCheckTxSize in Baseapp
  • add FlagChanCheckTxSize flag as cmd flag
  • add chan-check-tx-size field in app config.
  • set default chanCheckTxSize to 10000.

closes: #753

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue changed the title feat: add chCheckTxSize configuration of Baseapp Change to create chCheckTx with the value set in app config. Oct 25, 2022
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue self-assigned this Oct 25, 2022
@zemyblue zemyblue changed the title Change to create chCheckTx with the value set in app config. feat: change to create chCheckTx with the value set in app config. Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #756 (f8ab471) into main (f7d1830) will increase coverage by 0.01%.
The diff coverage is 93.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   62.15%   62.16%   +0.01%     
==========================================
  Files         879      879              
  Lines       99371    99385      +14     
==========================================
+ Hits        61760    61787      +27     
+ Misses      33991    33975      -16     
- Partials     3620     3623       +3     
Impacted Files Coverage Δ
server/config/toml.go 20.00% <ø> (ø)
server/config/config.go 45.07% <50.00%> (+0.07%) ⬆️
baseapp/baseapp.go 80.58% <100.00%> (+0.21%) ⬆️
baseapp/options.go 71.90% <100.00%> (+1.46%) ⬆️
simapp/simd/cmd/root.go 81.89% <100.00%> (+0.07%) ⬆️
x/collection/msgs.go 50.89% <0.00%> (-1.34%) ⬇️
x/wasm/keeper/keeper.go 86.53% <0.00%> (+0.36%) ⬆️
x/bank/simulation/operations.go 84.19% <0.00%> (+1.29%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️
x/token/msgs.go 53.99% <0.00%> (+4.56%) ⬆️
... and 1 more

server/config/toml.go Outdated Show resolved Hide resolved
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue requested a review from tkxkd0159 October 26, 2022 03:02
server/config/config.go Outdated Show resolved Hide resolved
server/start.go Outdated Show resolved Hide resolved
Signed-off-by: zemyblue <zemyblue@gmail.com>
@0Tech 0Tech self-requested a review October 26, 2022 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RequestCheckTxAsync channel count as config
4 participants