Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/foundation): remove unnecessary gov-mint feature #848

Merged
merged 4 commits into from
Jan 3, 2023
Merged

feat(x/foundation): remove unnecessary gov-mint feature #848

merged 4 commits into from
Jan 3, 2023

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Jan 2, 2023

Description

closes: #843

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@jaeseung-bae jaeseung-bae added the C:x/foundation x/foundation module label Jan 2, 2023
@jaeseung-bae jaeseung-bae self-assigned this Jan 2, 2023
@CLAassistant
Copy link

CLAassistant commented Jan 2, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #848 (8e3fdc4) into main (c8ce9cf) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   63.16%   63.08%   -0.09%     
==========================================
  Files         869      869              
  Lines      100426   100271     -155     
==========================================
- Hits        63434    63254     -180     
- Misses      33459    33518      +59     
+ Partials     3533     3499      -34     
Impacted Files Coverage Δ
simapp/app.go 85.31% <ø> (ø)
x/foundation/client/testutil/query.go 100.00% <ø> (ø)
x/foundation/client/testutil/suite.go 97.63% <ø> (-0.03%) ⬇️
x/foundation/client/testutil/tx.go 100.00% <ø> (ø)
x/foundation/codec.go 50.00% <ø> (ø)
x/foundation/genesis.go 82.85% <ø> (-0.36%) ⬇️
x/foundation/keeper/genesis.go 96.66% <ø> (-0.16%) ⬇️
x/foundation/keeper/grpc_query.go 4.27% <ø> (+0.17%) ⬆️
x/foundation/keeper/keys.go 97.95% <ø> (ø)
x/foundation/keeper/msg_server.go 86.95% <ø> (+2.04%) ⬆️
... and 5 more

@jaeseung-bae jaeseung-bae marked this pull request as ready for review January 2, 2023 04:26
@jaeseung-bae jaeseung-bae requested a review from 0Tech January 3, 2023 00:22
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tkxkd0159 tkxkd0159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeseung-bae jaeseung-bae merged commit 85695a4 into Finschia:main Jan 3, 2023
@jaeseung-bae jaeseung-bae deleted the feat/gov-mint branch January 3, 2023 04:47
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Jan 12, 2023
* main: (30 commits)
  chore(deps): Bump actions/cache from 3.2.2 to 3.2.3 (Finschia#860)
  chore(deps): Bump golang.org/x/crypto from 0.4.0 to 0.5.0 (Finschia#854)
  feat: Remove `x/wasm` module (Finschia#850)
  refactor: Remove useless stub BeginBlock/EndBlock methods (Finschia#853)
  feat: enable querying based on mempool status (only gRPC) (Finschia#840)
  feat(x/foundation): remove unnecessary gov-mint feature (Finschia#848)
  chore(deps): Bump actions/cache from 3.2.1 to 3.2.2 (Finschia#845)
  chore(deps): Bump github.com/mattn/go-isatty from 0.0.16 to 0.0.17 (Finschia#847)
  chore(deps): Bump actions/cache from 3.2.0 to 3.2.1 (Finschia#841)
  fix: apply foundation audit (Finschia#834)
  chore(deps): Bump actions/setup-go from 3.4.0 to 3.5.0 (Finschia#831)
  chore(deps): Bump actions/cache from 3.0.11 to 3.2.0 (Finschia#839)
  ci: automate release process (Finschia#829)
  chore(deps): Bump github.com/prometheus/common from 0.37.0 to 0.39.0 (Finschia#832)
  chore(deps): Bump goreleaser/goreleaser-action from 3 to 4 (Finschia#830)
  chore(deps): Bump github.com/magiconair/properties from 1.8.6 to 1.8.7 (Finschia#826)
  chore(deps): Bump technote-space/get-diff-action from 6.1.1 to 6.1.2 (Finschia#822)
  chore(deps): Bump golang.org/x/crypto from 0.2.0 to 0.4.0 (Finschia#828)
  feat: Get validator pubkey considering KMS (Finschia#821)
  Remove support for composite (BLS) key type (Finschia#817)
  ...

# Conflicts:
#	x/foundation/msgs.go
#	x/wasm/lbmtypes/codec.go
#	x/wasm/types/codec.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove gov minting function in the x/foundation
4 participants