Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add custom GetBlockWithTxs for lbm #891

Merged
merged 5 commits into from
Feb 10, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Feb 10, 2023

Description

move GetBlockWithTxs of lbm

  • roll back origin cosmos.tx.v1beta1.Service/GetBlockWithTxs
  • add lbm.tx.v1beta1.Service/GetBlockWithTxs.
  • lbm.tx.v1beta1.service.proto converted in x/auth/tx2 directory
  • cosmos.tx.v1beta1.Service/GetBlockWithTxs query api is deprecated.

related: #885

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue marked this pull request as draft February 10, 2023 02:18
@zemyblue zemyblue self-assigned this Feb 10, 2023
@zemyblue zemyblue added this to the v0.47.0-alpha1 milestone Feb 10, 2023
@zemyblue zemyblue changed the title feat!: separate lbm custom proto struct feat!: add custom GetBlockWithTxs for lbm Feb 10, 2023
@zemyblue zemyblue marked this pull request as ready for review February 10, 2023 05:28
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #891 (97c936b) into main (b886473) will increase coverage by 0.00%.
The diff coverage is 68.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #891   +/-   ##
=======================================
  Coverage   62.31%   62.31%           
=======================================
  Files         652      653    +1     
  Lines       79493    79497    +4     
=======================================
+ Hits        49534    49538    +4     
  Misses      27279    27279           
  Partials     2680     2680           
Impacted Files Coverage Δ
simapp/app.go 81.88% <0.00%> (-0.42%) ⬇️
x/auth/tx2/service.go 69.44% <69.44%> (ø)
x/auth/tx/service.go 71.17% <100.00%> (+2.12%) ⬆️
client/broadcast.go 53.19% <0.00%> (ø)
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️
x/upgrade/types/plan.go 95.83% <0.00%> (+6.64%) ⬆️

dudong2
dudong2 previously approved these changes Feb 10, 2023
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants