-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add custom GetBlockWithTxs
for lbm
#891
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a1.Service/GetBlockWithTxs.
zemyblue
changed the title
feat!: separate lbm custom proto struct
feat!: add custom Feb 10, 2023
GetBlockWithTxs
for lbm
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #891 +/- ##
=======================================
Coverage 62.31% 62.31%
=======================================
Files 652 653 +1
Lines 79493 79497 +4
=======================================
+ Hits 49534 49538 +4
Misses 27279 27279
Partials 2680 2680
|
dudong2
previously approved these changes
Feb 10, 2023
0Tech
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dudong2
approved these changes
Feb 10, 2023
This was referenced Feb 12, 2023
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
move
GetBlockWithTxs
of lbmcosmos.tx.v1beta1.Service/GetBlockWithTxs
lbm.tx.v1beta1.Service/GetBlockWithTxs
.lbm.tx.v1beta1.service.proto
converted inx/auth/tx2
directorycosmos.tx.v1beta1.Service/GetBlockWithTxs
query api is deprecated.related: #885
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml