Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay Widgets #1577

Closed
raymanfx opened this issue Feb 10, 2021 · 2 comments · Fixed by #1583
Closed

Overlay Widgets #1577

raymanfx opened this issue Feb 10, 2021 · 2 comments · Fixed by #1583

Comments

@raymanfx
Copy link
Collaborator

raymanfx commented Feb 10, 2021

One thing I'm missing in Druid right now is overlay type widgets. Common widgets that fit into this category are picklists, but also modal widgets. As a visual example, this is the material.io example overlay widget [1]:

Now I guess #429 (modal widgets) is related, but I'm not entirely sure whether it's the same thing. A full blown modal is a window that requires immediate attention and usually has buttons or other methods of control flow alteration (OK/Cancel/..). The example I linked in [1] is more of a 'simple' popover widget: you press a button and the list pops up. I guess it's technically just a Scroll<List<Button>>, since each element can be clicked to provoke an action.

Please let me know what you think.

EDIT 1
Some work for dropdown menus, modal widgets etc. has been done here: https://github.com/rjwittams/druid/commits/sub-window, but not merged back into upstream Druid (this repo). The current state of affairs is unclear, but I guess it would require some amount of work to rebase it onto the current HEAD.

[1] https://material.io/components/menus#dropdown-menu

@Ciantic
Copy link
Collaborator

Ciantic commented Feb 10, 2021

Have you tried the dropdown in nursery? https://github.com/linebender/druid-widget-nursery

Before websites we just did these with separate windows, which I think is a nicer way to do these than overlay on others. But I can see Overlay Widgets as useful too if they are not out of scope.

@rjwittams
Copy link
Collaborator

That branch of mine is all merged from a separate squashed branch.
I'm not sure if this issue really makes much sense given that subwindows do work in master, but specific widgets need to be written to use them.
I'm sure there will be improvements to make once more experience is gathered from using subwindows.

@Ciantic Ciantic linked a pull request Feb 16, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants