Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_alpha for Brush, Gradient, Image #67

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

waywardmonkeys
Copy link
Contributor

There is now a with_alpha to go along with multiply_alpha that sets the alpha to the given value. This makes it work the same as for colors with the same sort of API.

While doing this, some code for multiplying alpha on a gradient was moved to Gradient to make the interfaces the same on all things that support this.

Fixes #51.

There is now a `with_alpha` to go along with `multiply_alpha` that
sets the alpha to the given value. This makes it work the same as
for colors with the same sort of API.

While doing this, some code for multiplying alpha on a gradient
was moved to `Gradient` to make the interfaces the same on all
things that support this.

Fixes linebender#51.
Copy link
Contributor

@dfrg dfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Nov 28, 2024
Merged via the queue into linebender:main with commit 8d8c3d3 Nov 28, 2024
15 checks passed
@waywardmonkeys waywardmonkeys deleted the add-with_alpha branch November 28, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename with_alpha_factor, add set_alpha?
3 participants