Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically align => while typing or when saving #177

Closed
cabrinha opened this issue Jan 16, 2019 · 5 comments · Fixed by #186
Closed

Automatically align => while typing or when saving #177

cabrinha opened this issue Jan 16, 2019 · 5 comments · Fixed by #186
Assignees
@glennsarti
Labels
enhancement New feature or request
Milestone
0.22.0

Comments

@cabrinha
Copy link

Summary of the new feature

Automatic => alignment, as I type, or when saving, or with a hotkey.

For example:

As a user

I would like to automatically automatically align => as I type, or when saving, or with a hotkey.

so that I don't have to remember to do it myself or run lint, then go back and hit space/tab until all hashes are properly aligned.
@jpogran
Copy link
Contributor

jpogran commented Jan 20, 2019

Thanks for helping us prioritize this

@jpogran
Copy link
Contributor

jpogran commented May 24, 2019

Link puppetlabs/puppet-vscode#390 and puppetlabs/puppet-vscode#289

glennsarti referenced this issue in glennsarti/puppet-vscode Jul 15, 2019
@glennsarti
(GH-465) Align hash rocket as you type
3e1a537 
This commit adds an auto-aligner for the hash rocket (=>) for .pp files.  This
feature is hidden behind the 'hashrocket' featureflag as it may have unintended
consequences and reformat user's files unexpectedly.

The auto-align triggers on the `>` character.
* The provider then determines if the user is in a hashrocket.
* It then looks at the preceeding and proceeding lines to determine the block
  of hash rockets to consider
* Once it has block of lines, it determines the smallest hash rocket location
  and edits the text file appropriately.
@trenta
Copy link

trenta commented Aug 13, 2019

I just moved from Vim native to vscode and was using https://github.com/rodjek/vim-puppet which did the auto aligning really well and would love to see this implemented.

@jpogran jpogran transferred this issue from puppetlabs/puppet-vscode Sep 6, 2019
@glennsarti glennsarti mentioned this issue Sep 6, 2019
Closed
6 tasks
@jpogran jpogran added the enhancement New feature or request label Sep 6, 2019
@jpogran jpogran added this to the 0.22.0 milestone Sep 6, 2019
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 11, 2019
@glennsarti
(puppetlabsGH-177) Update LSP introspection for missing classes
434f698 
Previously only the main protocol.d.ts file was introspected for ruby classes
however the LSP protocol is actually split of many files.  This commit changes
the introspection tool to parse all of the files and import them into the ruby
lsp namespace.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 11, 2019
@glennsarti
(puppetlabsGH-177) Fetch and understand the client configuration
0dbd5b3 
Previously the language server did not need to act on client configuration and
it was all passed in via the command line.  This commit;
* Introduces a new class (LanguageClient) which is responsible for handling the
  configuration of the client from the server
* The language client stores the client capabilites and any settings at the
  client level, that the server consumes
* The LanguageClient class can register features dynamically
* Uses dynamic registration of the `workspace/didChangeConfiguration` method
  where available.
* Understands the difference between the old Client Push settings model and
  the newer Server Pull settings model, and can adapt appropriately
* Adds tests for these scenarios.

Later commits will actually implement caching the required settings.  This
commit is just focused on the plumbing to get the settings from the client.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 11, 2019
@glennsarti
(puppetlabsGH-177) Fetch and understand the client configuration
fb96652 
Previously the language server did not need to act on client configuration and
it was all passed in via the command line.  This commit;
* Introduces a new class (LanguageClient) which is responsible for handling the
  configuration of the client from the server
* The language client stores the client capabilites and any settings at the
  client level, that the server consumes
* The LanguageClient class can register features dynamically
* Uses dynamic registration of the `workspace/didChangeConfiguration` method
  where available.
* Understands the difference between the old Client Push settings model and
  the newer Server Pull settings model, and can adapt appropriately
* Adds tests for these scenarios.

Later commits will actually implement caching the required settings.  This
commit is just focused on the plumbing to get the settings from the client.
@glennsarti glennsarti mentioned this issue Sep 11, 2019
Merged
jpogran added a commit that referenced this issue Sep 12, 2019
@jpogran
Merge pull request #179 from glennsarti/get-client-config
f50d75c 
(GH-177) Add ability to fetch the client configuration
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 17, 2019
@glennsarti
(puppetlabsGH-177) Track dynamic registrations
9168a19 
Previously capability registrations were assumed to only have one possible
reqeuest per method however this isn't true.  Also the request ID is needed in
order to unregister a capability.  This commit;
* Modifies the Language Client to track registrations that are in progress and
  have completed
* Now processes error messages so that registration tracking can fail tracked
  registrations
* Adds tests for these scenarios
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 17, 2019
@glennsarti
(puppetlabsGH-177) Refactor message_router as property of Language Cl…
9362435 
…ient

Previously the message router was passed in as a method parameter however as
almost all methods require the message router, this commit changes the
initializer to pass in the message router at object create time.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 17, 2019
@glennsarti
(puppetlabsGH-177) Add unregistering of capabilities
b0e3a67 
Previously client capabilities could be dynamically registered.  This commit
adds the logic and track to dynamically unregister a capability;
* Adds the unregister_capability and parse_unregister_capability_response!
  methods
* Adds the client/unregisterCapability notification handler
* Adds tests for unregistering
@glennsarti glennsarti mentioned this issue Sep 17, 2019
Merged
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 17, 2019
@glennsarti
(puppetlabsGH-177) Fix workspace/configuration settings hash
00f7548 
Previously the settings were passed directly from the response into the
client for processing however this does not emulate the legacy settings hash.

This commit adds the original scope onto the settings hash so it appears like
the legacy hash e.g. puppet.editorservices.abc instead of editorserivces.abc
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 17, 2019
@glennsarti
(puppetlabsGH-177) Move warning due to initialized notification
9d13ba8 
While technically the protocol does allow the server to send window/showMessage
notifcations during initialization, it's better to send the warning at the
end of initialization i.e. at the initialized notification.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 17, 2019
@glennsarti
(puppetlabsGH-177) Add registrations and settings for on type formatting
db97c1a 
Now that the Language Client can process client settings, and dynamic
registrations it is now possible to setup the server to register to receive the
onTypeFormatting request.  This commit:

* Responds to the 'puppet.editorService.formatOnType.enable' client setting
* Dynamically registers the provider if dynamic registration is possible
  otherwise uses static registration
* Adds a format_on_type method on the Language Client to track whether this
  feature is enabled
* Adds dummy response to the `textDocument/onTypeFormatting` request
* Adds tests for the client interacting with the settings
@glennsarti glennsarti mentioned this issue Sep 17, 2019
Merged
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Sep 17, 2019
@glennsarti
(puppetlabsGH-177) Add auto-align hash rocket feature
87fa677 
Previously the onTypeFormatting provider was created and responds to client
settings, turning it on and off appropriately.  This commit actually adds the
on type formatter:

* Only for puppet manifests (.pp)
* Uses puppet-lint lexer to tokenise the document and uses the tokens to
  determine indenting
* Will not operate if the document is over 4KB in size or the client is using
  tabs instead of spaces
* Adds tests for the formatting
@glennsarti glennsarti mentioned this issue Sep 17, 2019
Merged
@glennsarti
Copy link
Contributor

Almost there ... lots of behind-the-scenes changes to make before I could fix the hash-rockets.

jpogran added a commit that referenced this issue Sep 18, 2019
@jpogran
Merge pull request #184 from glennsarti/unreg-client-msgs
58b62de 
(GH-177) Dynamically unregister capabilities
jpogran added a commit that referenced this issue Sep 18, 2019
@jpogran
Merge pull request #185 from glennsarti/format-on-type
4f0a80f 
(GH-177) Add registrations and settings for on type formatting
jpogran added a commit that referenced this issue Sep 18, 2019
@jpogran
Merge pull request #186 from glennsarti/align-hash-rockets
44afb3c 
(GH-177) Add auto-align hash rocket feature
@glennsarti
Copy link
Contributor

And we're merged! Will be available next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glennsarti glennsarti

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.22.0
4 participants
@jpogran @cabrinha @trenta @glennsarti