Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puppet Node Graph json method #221

Closed
jpogran opened this issue Mar 11, 2020 · 0 comments · Fixed by #226
Closed

Puppet Node Graph json method #221

jpogran opened this issue Mar 11, 2020 · 0 comments · Fixed by #226
Assignees
@jpogran
Labels
enhancement New feature or request
Milestone
0.25.0

Comments

@jpogran
Copy link
Contributor

jpogran commented Mar 11, 2020

To support puppetlabs/puppet-vscode#613, the node graph method needs to return json instead of dot graphs
@jpogran jpogran added the enhancement New feature or request label Mar 11, 2020
@jpogran jpogran added this to the 0.25.0 milestone Mar 11, 2020
@jpogran jpogran self-assigned this Mar 11, 2020
jpogran added a commit to jpogran/puppet-editor-services that referenced this issue Mar 11, 2020
@jpogran
(puppetlabsGH-221) Puppet Node Graph to json
0fbcf8a 
This commit changes the Node Graph method to return a json data hash
instead of a dot graph to support puppetlabs/puppet-vscode#613
@jpogran jpogran mentioned this issue Mar 11, 2020
Closed
jpogran added a commit to jpogran/puppet-editor-services that referenced this issue Mar 11, 2020
@jpogran
(puppetlabsGH-221) Puppet Node Graph to json
522e7c5 
This commit changes the Node Graph method to return a json data hash
instead of a dot graph to support puppetlabs/puppet-vscode#613
jpogran added a commit to jpogran/puppet-editor-services that referenced this issue Mar 18, 2020
@jpogran
(puppetlabsGH-221) Puppet Node Graph JSON
c0b99e1 
This removes the dot graph implementation and replaces it with a json
data hash implementation. This is used by the newer client
implementation using the cytoscape library.
jpogran added a commit to jpogran/puppet-editor-services that referenced this issue Mar 18, 2020
@jpogran
(puppetlabsGH-221) Puppet Node Graph JSON
f3aec67 
This removes the dot graph implementation and replaces it with a json
data hash implementation. This is used by the newer client
implementation using the cytoscape library.
jpogran added a commit to jpogran/puppet-editor-services that referenced this issue Mar 18, 2020
@jpogran
(puppetlabsGH-221) Puppet Node Graph JSON
643ae45 
This removes the dot graph implementation and replaces it with a json
data hash implementation. This is used by the newer client
implementation using the cytoscape library.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Mar 20, 2020
@glennsarti
(puppetlabsGH-221) Add generic Graph response
109d8af 
Previously the NodeGraph response was entirely DOT language centric however the
LSP should really be returning structured data which the client can deal with
as it is trivial to convert it to DOT file, or whatever the visualisation
library requires.  This commit:

* Changes the response object to GraphResponse which has an edges and vertices
  array of hashes.

* Updates all of the the puppet_compilenodegraph LSP method to use the new
  GraphResponse type.

* Updates all of the tests for the new response object type.
@glennsarti glennsarti mentioned this issue Mar 20, 2020
Closed
3 tasks
jpogran added a commit to jpogran/puppet-editor-services that referenced this issue Mar 25, 2020
@jpogran
(puppetlabsGH-221) Puppet Node Graph Response
0991e17 
This removes the dot graph implementation and replaces it with an object
that contains all the edges and vertices from the compiled node graph.

This is used by the newer client implementation using the cytoscape
library.
@jpogran jpogran mentioned this issue Mar 25, 2020
Merged
jpogran added a commit to jpogran/puppet-editor-services that referenced this issue Mar 25, 2020
@jpogran
(puppetlabsGH-221) Puppet Node Graph Response
06588f9 
This removes the dot graph implementation and replaces it with an object
that contains all the edges and vertices from the compiled node graph.

This is used by the newer client implementation using the cytoscape
library.
jpogran added a commit that referenced this issue Mar 25, 2020
@jpogran
Merge pull request #226 from jpogran/puppet-node-graph
9b41dcf 
(GH-221) Puppet Node Graph Response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpogran jpogran

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.25.0
1 participant
@jpogran