-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: extract works with template string id's #1027
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/2J7df8q4wwA5mtL9S1CUN9RAeqgz |
Codecov Report
@@ Coverage Diff @@
## main #1027 +/- ##
==========================================
+ Coverage 83.35% 83.36% +0.01%
==========================================
Files 53 53
Lines 1622 1623 +1
Branches 436 438 +2
==========================================
+ Hits 1352 1353 +1
Misses 157 157
Partials 113 113
Continue to review full report at Codecov.
|
Looks good mate, but could you me explain what does it mean? |
@semoal If you are asking about this object |
Yes, i was asking about the object quasis and the cooked value. Also, another question, shouldn't be like this?: props[key.name] = (isIdLiteral && value?.quasis[0]?.value?.cooked) || value.value || undefined When is a template literal always value.value it's undefined? |
Well, there is no big difference, but anyway I have optimized it. |
This PR closes issue #957 macro
t
with template string id.