Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vietnamese support | bug #1033

Closed
seeden opened this issue Apr 8, 2021 · 12 comments · Fixed by #1328
Closed

Vietnamese support | bug #1033

seeden opened this issue Apr 8, 2021 · 12 comments · Fixed by #1328
Labels

Comments

@seeden
Copy link

seeden commented Apr 8, 2021

From unknown reason lingui is not able to compile few Vietnamese strings.
It is working fine when I remove it from my .po file.
I am using latest version 3.8.2

Here is content of .po file

#: src/components/farm/FarmYourHarvesterNetwork.tsx:58
msgid "A harvester is a service running on a machine where plot(s) are actually stored. A farmer and harvester talk to a full node to see the state of the chain. View your network of connected harvesters below Learn more"
msgstr "Harvester là một dịch vụ chạy trên một  máy chứa các tệp plot  . Một \bfarmer và harvester tương tác với một nút đầy đủ để xác định trạng thái của chuỗi. Xem các harvester được kết nối của bạn dưới đây Tìm hiểu thêm"


#: src/electron/main.ts:296
msgid "Contribute on GitHub"
msgstr "Đóng góp �qua GitHub"

I see next error stacktrace:

/Users/seeden/Documents/git/chia-blockchain/chia-blockchain-gui/node_modules/@lingui/cli/api/compile.js:89
    throw new Error("Can't parse message. Please check correct syntax: \"".concat(message, "\""));
    ^

Error: Can't parse message. Please check correct syntax: "Đóng góp qua GitHub"
    at compile (/Users/seeden/Documents/git/chia-blockchain/chia-blockchain-gui/node_modules/@lingui/cli/api/compile.js:89:11)
    at /Users/seeden/Documents/git/chia-blockchain/chia-blockchain-gui/node_modules/@lingui/cli/api/compile.js:45:51
    at Array.map (<anonymous>)
    at createCompiledCatalog (/Users/seeden/Documents/git/chia-blockchain/chia-blockchain-gui/node_modules/@lingui/cli/api/compile.js:37:43)
    at /Users/seeden/Documents/git/chia-blockchain/chia-blockchain-gui/node_modules/@lingui/cli/lingui-compile.js:91:66
    at Array.forEach (<anonymous>)
    at /Users/seeden/Documents/git/chia-blockchain/chia-blockchain-gui/node_modules/@lingui/cli/lingui-compile.js:61:14
    at Array.forEach (<anonymous>)
    at command (/Users/seeden/Documents/git/chia-blockchain/chia-blockchain-gui/node_modules/@lingui/cli/lingui-compile.js:50:18)
    at compile (/Users/seeden/Documents/git/chia-blockchain/chia-blockchain-gui/node_modules/@lingui/cli/lingui-compile.js:135:12)
@semoal
Copy link
Contributor

semoal commented Apr 8, 2021

Could you give me the current message which is causing the error? So i can add it to the testing suite -> reproduce -> and fix it =)

@seeden
Copy link
Author

seeden commented Apr 8, 2021

It is already in the description.

#: src/components/farm/FarmYourHarvesterNetwork.tsx:58
msgid "A harvester is a service running on a machine where plot(s) are actually stored. A farmer and harvester talk to a full node to see the state of the chain. View your network of connected harvesters below Learn more"
msgstr "Harvester là một dịch vụ chạy trên một  máy chứa các tệp plot  . Một \bfarmer và harvester tương tác với một nút đầy đủ để xác định trạng thái của chuỗi. Xem các harvester được kết nối của bạn dưới đây Tìm hiểu thêm"


#: src/electron/main.ts:296
msgid "Contribute on GitHub"
msgstr "Đóng góp �qua GitHub"

@semoal
Copy link
Contributor

semoal commented Apr 8, 2021

Alright, we don't need to change anything. Just remove that \b from the msgstr is not valid

@semoal
Copy link
Contributor

semoal commented Apr 8, 2021

9b2705f
Just pushed a commit for improving the log if some syntax is not valid. :)

Will be released in a few minutes

@seeden
Copy link
Author

seeden commented Apr 8, 2021

This is not work as well and it is without \b

#: src/electron/main.ts:296
msgid "Contribute on GitHub"
msgstr "Đóng góp �qua GitHub"

Can you check it as well? Thank you

@semoal
Copy link
Contributor

semoal commented Apr 8, 2021

I can't see that character mate, dunno how to test it hehe
Screenshot 2021-04-08 at 19 20 16

@semoal
Copy link
Contributor

semoal commented Apr 8, 2021

https://stackblitz.com/edit/typescript-9kphuq?devtoolsheight=33&file=index.ts
You can use this website to test if that library is the problem or not =)

@seeden
Copy link
Author

seeden commented Apr 8, 2021

@semoal
Copy link
Contributor

semoal commented Apr 8, 2021

Alright then, I'll create a bug in his repository. I've tried with his new version which is in beta and works good, but it's a major release and breaks lingui so i'll have to find time to work on it :/

@stale
Copy link

stale bot commented Jun 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@seeden
Copy link
Author

seeden commented Jun 14, 2021

still an issue

@Martin005 Martin005 reopened this Jan 7, 2023
@Martin005
Copy link
Contributor

Hello @seeden!
Could you please confirm whether this issue still persists?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants