Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't push pseudoLocale to translation.io provider #1161

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

mdirolf
Copy link
Contributor

@mdirolf mdirolf commented Oct 31, 2021

I honestly haven't tested this change but hopefully this will fix an issue where having a pseudo locale configured in lingui prevents the translation.io sync from working with:

Synchronization with Translation.io failed: Invalid 'target_languages': pseudo. Please use existing language codes (https://translation.io/docs/languages) or custom languages (https://translation.io/blog/custom-languages).

@vercel
Copy link

vercel bot commented Oct 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/4SCxLDLtDWHCyKNBMsUoidvwJNCX
✅ Preview: https://js-lingui-git-fork-mdirolf-patch-1-lingui-js.vercel.app

@semoal semoal changed the title Don't (attempt to) push pseudoLocale to tranlation.io fix: don't push pseudoLocale to translation.io provider Nov 26, 2021
@semoal semoal merged commit 5d2186b into lingui:main Nov 26, 2021
@semoal
Copy link
Contributor

semoal commented Nov 26, 2021

LGTM, thanks!!

@semoal
Copy link
Contributor

semoal commented Nov 26, 2021

Released with 3.13.0, enjoy it!
Sorry for the late release, has been really busy lately.
https://github.com/lingui/js-lingui/releases/tag/v3.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants