fix(cli): extract with --overwrite should fallback to key #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we run `lingui extract --overwrite` only translations with a custom id + message were working properly. However, if there is no default `message` but only the `id`, `--overwrite` option was resetting the translation to empty string instead of using `key` as default This was working properly when a "new" key is added, but not when we update the key (on merge) Also update snapshot `go-gettext.test.ts.snap` because it fails on master
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/8ZX6E4x3uiUS9ZY3UbPnkgRPnDMm |
|
Super! Thanks mate |
|
Released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run
lingui extract --overwriteonly translations with a custom id + message were working properly.However, if there is no default
messagebut only theid,--overwriteoption was resetting the translation to empty string instead of usingkeyas defaultThis was working properly when a "new" key was added, but not when we update the key (on merge)
Also update snapshot
go-gettext.test.ts.snapbecause it fails on masterFixes #1162
See this repository to reproduce the issue