Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch to cosmiconfig-typescript-loader #1247

Merged

Conversation

marek-saji
Copy link
Contributor

@marek-saji marek-saji commented May 30, 2022

Description

Switch from unmaintained @endemolshinegroup/cosmiconfig-typescript-loader to cosmiconfig-typescript-loader.

Why?

I’ve run into a problem in one of my projects where running jest gave errors.

Error: Jest: Failed to parse the TypeScript config file …/jest.config.ts
  Error: Debug Failure. False expression: Non-string value passed to
  `ts.resolveTypeReferenceDirective`, likely by a wrapping package
  working
  with an outdated `resolveTypeReferenceDirectives` signature. This is
  probably not a problem in TS itself.
      at readConfigFileAndSetRootDir
      (…/node_modules/jest-config/build/readConfigFileAndSetRootDir.js:136:13)
          at readConfig
          (…/node_modules/jest-config/build/index.js:233:18)
              at readConfigs
              (…/node_modules/jest-config/build/index.js:420:26)
                  at runCLI
                  (…/node_modules/@jest/core/build/cli/index.js:132:59)
                      at Object.run
                      (…/node_modules/jest-cli/build/cli/index.js:155:37)

Caused by ts-node@9 (jestjs/jest#12655) and upgrading to 10 was hold off by lingui depending on
@endemolshinegroup/cosmiconfig-typescript-loader.

And generally speaking — better to make a switch from a package that was
last updated two years ago and seems abandoned.

Checklist

  • Includes tests
  • Includes documentation

@vercel
Copy link

vercel bot commented May 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
js-lingui ✅ Ready (Inspect) Visit Preview May 30, 2022 at 2:11PM (UTC)

@marek-saji marek-saji changed the title Switch to cosmiconfig-typescript-loader improvement: Switch to cosmiconfig-typescript-loader May 30, 2022
@@ -72,6 +72,26 @@ Documentation: https://lingui.js.org/ref/conf.html
Please update your configuration.


Documentation: https://lingui.js.org/ref/conf.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's strange that this snapshot it's added right? Looks like the config is not loaded correctly

@stale
Copy link

stale bot commented Sep 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 8, 2022
@semoal semoal changed the title improvement: Switch to cosmiconfig-typescript-loader feat: Switch to cosmiconfig-typescript-loader Sep 12, 2022
@semoal semoal merged commit 118d183 into lingui:main Sep 12, 2022
@stale stale bot removed the wontfix label Sep 12, 2022
@marek-saji marek-saji deleted the chore/switch-to-cosmiconfig-typescript-loader branch December 14, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants