feat: lingui extract should fail with a non-zero exit code when there are extraction failures
#1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
decafdennis
changed the title
lingui extract should fail have a non-zero exit code when there are extraction failureslingui extract should fail with a non-zero exit code when there are extraction failures
Codecov ReportBase: 82.52% // Head: 82.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1299 +/- ##
==========================================
- Coverage 82.52% 82.47% -0.05%
==========================================
Files 56 56
Lines 1785 1792 +7
Branches 500 503 +3
==========================================
+ Hits 1473 1478 +5
Misses 184 184
- Partials 128 130 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
decafdennis
changed the title
lingui extract should fail with a non-zero exit code when there are extraction failureslingui extract should fail with a non-zero exit code when there are extraction failures
semoal
changed the title
lingui extract should fail with a non-zero exit code when there are extraction failureslingui extract should fail with a non-zero exit code when there are extraction failures
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lingui extractprints extraction failures (such asCannot process file [path]: Different defaults for the same message ID.) to the console but then finishes with a zero exit code. When run unattended in a CI job, this means files with failures are skipped during extraction and their messages may then be missing in a production build.This PR propagates the
booleanresult(s) from the extractor all the way up into the CLI command. There was already code to handle it and doprocess.exit(1)when the result isfalse.