-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compile): remove verbose output when using template (*.pot) #1388
fix(compile): remove verbose output when using template (*.pot) #1388
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
13b18d0
to
5aaaf95
Compare
@andrii-bodnar any doubts here? |
Will finish the review today |
991a17c
to
a65d662
Compare
Codecov ReportBase: 68.40% // Head: 69.75% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1388 +/- ##
==========================================
+ Coverage 68.40% 69.75% +1.35%
==========================================
Files 72 72
Lines 2124 2123 -1
Branches 573 572 -1
==========================================
+ Hits 1453 1481 +28
+ Misses 542 507 -35
- Partials 129 135 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
What's left to merge this pr? |
@thekip the codecov reports a 2.70% coverage decrease, could you please check why this is happening? |
Because codecov incorrectly calculate coverage. It calculates how many procents of imported files are covered. So if you have 100 files and 1 test which imports exactly one file and cover all lines in that file. codecov will show 100% coverage even when other 99 files not touched at all. Exactly that is happened here, I added to test file which was never tested and imported in suite before and this file expanded "base" for a coverage. |
It's not related to codecov itself, it related to how coverage tools works in general. They know only about files which were included in program when coverage was collected |
@thekip thank you! |
a65d662
to
050e794
Compare
050e794
to
231e0d0
Compare
rebased and updated |
I have no idea why windows tests a failing. There nothing related in this PR May be simple rerun will help |
@thekip it happens sometimes for unknown reason 😬 |
Description
When using flow with ".pot" file it generates unneeded log entries on every catalog load.
This was done unintentional and fixed in this PR.
I also added integration test for the
compile
cli command covering this and related cases.There is also a growing problem with
@lingui/conf
package. Typings in src and and index.d.ts are mismatched, and bringing potential problems and blocking from implementing standard flow. I hope i will take this into work in the near future.Types of changes
Fixes # (issue)
Checklist