Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always honor process.env.LINGUI_CONFIG #1447

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented Feb 19, 2023

fixes: #1416

Description

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Feb 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 19, 2023 at 4:09PM (UTC)

@github-actions
Copy link

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 1.76 KB (0%)
./packages/detect-locale/build/esm/index.js 812 B (0%)
./packages/react/build/esm/index.js 1.79 KB (0%)
./packages/remote-loader/build/esm/index.js 7.29 KB (0%)

@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Base: 72.24% // Head: 72.38% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (67597f2) compared to base (6ddbed9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1447      +/-   ##
==========================================
+ Coverage   72.24%   72.38%   +0.14%     
==========================================
  Files          74       74              
  Lines        1895     1894       -1     
  Branches      511      510       -1     
==========================================
+ Hits         1369     1371       +2     
+ Misses        422      419       -3     
  Partials      104      104              
Impacted Files Coverage Δ
packages/cli/src/lingui-extract-template.ts 0.00% <ø> (ø)
packages/cli/src/lingui-extract.ts 0.00% <ø> (ø)
packages/conf/src/getConfig.ts 93.75% <100.00%> (+7.08%) ⬆️
packages/macro/src/index.ts 94.11% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar andrii-bodnar merged commit 4aa80de into lingui:next Feb 20, 2023
@timofei-iatsenko timofei-iatsenko deleted the fix/lingui-config-env branch February 20, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

different config loaded for macro and cli when use extract --config if config file is under cwd/subfolder
3 participants