We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
pure variable variant is omitted from the extracted message, resulting in invalid ICU format
select(variant, { other: localeDateAndTime, today: `Today at ${localeTime}`, tomorrow: `Tomorrow at ${localeTime}`, yesterday: `Yesterday at ${localeTime}`, })
right now, other is omitted from the extracted message
other
{variant, select, today {Today at {localeTime}} tomorrow {Tomorrow at {localeTime}} yesterday {Yesterday at {localeTime}}
and according to https://format-message.github.io/icu-message-format-for-translators/editor.html, this format is invalid as missing other there.
Expected behavior
expect other is included
{variant, select, other {{localeDateAndTime}} today {Today at {localeTime}} tomorrow {Tomorrow at {localeTime}} yesterday {Yesterday at {localeTime}}
Additional context
not sure if this is v4 only, only tested on v4 tho
The text was updated successfully, but these errors were encountered:
taozhou-glean
Successfully merging a pull request may close this issue.
Describe the bug
pure variable variant is omitted from the extracted message, resulting in invalid ICU format
right now,
other
is omitted from the extracted messageand according to https://format-message.github.io/icu-message-format-for-translators/editor.html, this format is invalid as missing
other
there.Expected behavior
expect
other
is included{variant, select, other {{localeDateAndTime}} today {Today at {localeTime}} tomorrow {Tomorrow at {localeTime}} yesterday {Yesterday at {localeTime}}
Additional context
not sure if this is v4 only, only tested on v4 tho
The text was updated successfully, but these errors were encountered: