-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract CLI prints "Missing message ID" warning when used with defineMessage() #1538
Comments
Hi @timomeh, currently, we have the pre-released to see all the changes in v4, please visit the releases page. |
It doesn't show the log in |
@timomeh great! We are going to officially release the v4 version soon (it's a matter of a few weeks) so the fix won't be applied to the v3 version. Probably, we can close this issue, what do you think? |
Sounds totally reasonable, can be closed! Tried out v4 in our project and it seemed to work out of the box – besides the fact that it re-wrote all IDs due to the new autogenerated IDs 😬 I'll then just wait for v4 to be released |
Describe the bug
Running
lingui extract
prints "Missing message ID, skipping" to the console when you're passing the Message Descriptor fromdefineMessage()
intoi18n._()
.Using
defineMessage
in combination withi18n._
is a documented pattern, see the macro usage in the docs. The extraction still works, but the output is making it look like there's an issue.I think this was introduced in #1309, as part of the feature to also extract messages fromEdit: Looks like my suspicion was wrong. It also happens in 3.14.0. It doesn't happen in 3.13.3.i18n._()
To Reproduce
Given this code:
Run
lingui extract
. See logged output:Expected behavior
The logged warnings should not appear.
Additional context
The text was updated successfully, but these errors were encountered: