feat: allow comment prop on react Trans component

[j4hr3n]

Tested by publishing to Verdaccio and installing in a project of mine. Worked like a charm. The React Trans tests even use comment in jsx-without-macros.js.

Description

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Fixes # (issue)

#1713

Checklist

• I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
js-lingui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 28, 2023 7:59am

[github-actions]

size-limit report 📦

Path	Size
./packages/core/dist/index.mjs	2.76 KB (0%)
./packages/detect-locale/dist/index.mjs	721 B (0%)
./packages/react/dist/index.mjs	1.59 KB (0%)
./packages/remote-loader/dist/index.mjs	7.24 KB (0%)

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (dc82882) 76.01% compared to head (063262a) 76.01%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1718   +/-   ##
=======================================
  Coverage   76.01%   76.01%           
=======================================
  Files          79       79           
  Lines        2039     2039           
  Branches      524      524           
=======================================
  Hits         1550     1550           
  Misses        376      376           
  Partials      113      113           

Impacted Files	Coverage Δ
packages/react/src/Trans.tsx	90.90% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[timofei-iatsenko]

Please add a separate test case for that. This will ensure it will not break in future or someone will not change this functionality.

[j4hr3n]

Please add a separate test case for that. This will ensure it will not break in future or someone will not change this functionality.

@thekip where would you like me to add a test for this?

[timofei-iatsenko]

@j4hr3n i've just checked, there is already a test for comment in Trans component. So just ignore my previous comment.

[andrii-bodnar]

@j4hr3n thank you!