Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lingui extract --verbose - better error handling #180

Closed
vsnig opened this issue Mar 10, 2018 · 2 comments
Closed

lingui extract --verbose - better error handling #180

vsnig opened this issue Mar 10, 2018 · 2 comments
Labels
📦 cli good first issue

Comments

@vsnig
Copy link

vsnig commented Mar 10, 2018 •
edited
Loading

Right now srcFilename is outputted after successful extraction. When there has been an error during extraction we can't see which file caused the error.

I propose to output srcFilename before extraction and after successful extraction output "Success". Something along these lines.

    console.log(_chalk.default.blue(`Processing ${srcFilename}`));
    var extracted = ...

    if (extracted && verbose) console.log(_chalk.default.green("Success"));
@tricoder42
Copy link
Contributor

Sounds reasonable, interested in sending PR?

@tricoder42
Copy link
Contributor

Fixed in latest release v2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📦 cli good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tricoder42 @vsnig