Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite-plugin): add support for vite@5 #1827

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

monholm
Copy link
Contributor

@monholm monholm commented Jan 3, 2024

Description

This PR widens the range of accepted peer dependency versions for vite in the vite-plugin to add support for vite@5.

The error mentioned in #1805 (No loader is configured for ".po" files) was fixed in vite@5.0.9 (see: vitejs/vite@129d0d0). This was the only error hindering vite@5 support based on our testing (and the comments in #1805) besides the peer dependency version range :)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes #1805

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

The `No loader is configured for ".po" files` was fixed in `vite@5.0.9`.

Resolves lingui#1805
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 7:47pm

Copy link

github-actions bot commented Jan 3, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.81 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd269b6) 76.39% compared to head (355fd96) 76.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1827   +/-   ##
=======================================
  Coverage   76.39%   76.39%           
=======================================
  Files          81       81           
  Lines        2072     2072           
  Branches      529      529           
=======================================
  Hits         1583     1583           
  Misses        377      377           
  Partials      112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timofei-iatsenko
Copy link
Collaborator

Thanks!

@andrii-bodnar andrii-bodnar merged commit 5548d26 into lingui:main Jan 4, 2024
16 checks passed
@monholm monholm deleted the feat/vite-plugin-vite-5-support branch January 4, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update @lingui/vite-plugin to support Vite 5
3 participants